Update PR template - #2063
Merged
Merged
Conversation
Split Impact section into two. First section "Parts concerned" characterizes which part of REMIND has been modified
In order to ensure the progress tracker of each PR is representative of the actual state of the PR RSE wants to enforce that users delete the unselected checkboxes in the "Type of change" section. The checklist itself counts towards the state of the PR and is left unchanged. Users that forgot to delete checkboxes will receive an automated comment on their PR, also the template check will fail
…_pr_template Enforce checkbox removal in pr template
LaviniaBaumstark
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
No lines will be deleted anymore.
Check boxes are only used in the checklist at the bottom to track the progress.
Relevant type of changes are indicated using emojicodes but not check boxes.
Type of change
Checklist:
remind2where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switcheslog.txtfile of my runs for newly introduced summation, fixing or variable name errorsFAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctly