Rework of REMIND climate assessment integration - Reporting - #2082
Merged
Conversation
added 6 commits
April 8, 2025 19:32
- The climate reporting script `MAGICC7_AR6.R` was has been consolidated using the `remindClimateAssessment` and `piamenv` packages - List `climateAssessmentConfig` contains all directories and file names relevant to set up a climate assessment run - Python environment handling is done by `piamenv::condaInit` and `piamenv::condaRun` - One drawback in the new implementation is that logs are *not printed linewise* but dumped all at once - Run time reporting for various parts of the script was implemented by storing run times in a named vector. `reportRunTimes` generates a report and attaches it to the log file
- Moved pre-/post-processing into dedicated functions - Restructured script
Contributor
Author
|
remindClimateAssessment: Can't find package called remindClimateAssessment.We need to add |
tonnrueter
force-pushed
the
dev/ca_rework_pt1
branch
from
April 10, 2025 14:34
bc2328c to
f38b429
Compare
LaviniaBaumstark
approved these changes
Apr 11, 2025
gabriel-abrahao
approved these changes
Apr 11, 2025
gabriel-abrahao
left a comment
Contributor
There was a problem hiding this comment.
That is awesome, thanks for the great work Tonn!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
First part of the reworking the REMIND climate assessment integration. Affects climate reporting via
MAGICC7_AR6.RScript has been consolidated using the
remindClimateAssessmentandpiamenvpackagesPython environment handling is done by
piamenv::condaInitandpiamenv::condaRunconda run-based Python integration. This alleviates interference between R and Python environmentsscripts/input/climate_assessment_*.Rtopiamenv/remindClimateAssessmentusageremindClimateAssessmenthandles all aspects of setting up runs of IIASA'sclimate-assessmentlibraryclimateAssessmentConfigcontains all directories and file names relevant to set up a climate assessment runreportRunTimesgenerates a report and attaches it to the log fileremindClimateAssessment::dumpToGdxremindClimateAssessment::archiveClimateAssessmentDatastores climate assessment data of a particular run in a tar archiveType of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)
/p/tmp/tonnru/remind/output/SSP2-NPi2025_2025-04-04_19.32.43