Restructure core bounds - #2086
Conversation
|
Why is this still a draft? Should it be merged for v3.5.1? |
|
Never had time to properly test and merge it, so it should stay as a draft =( |
…1 instead of previous 0.03113 that was erroneous)
| biopyrchp "biomass pyrolysis to biochar plus heat and power (established industrial)" | ||
| biopyrliq "biomass pyrolysis to biochar plus liquids (combined with Fischer-Tropsch plant, advanced industrial)" | ||
| / | ||
|
|
There was a problem hiding this comment.
i added this set to replace long conditions in the bounds like
loop(te $ (sameas(te, biopyrchp) or sameas(te, biopyrliq) or sameas(te .....
|
Thanks for looking through it, I integrated your suggestions and increased the similarity with declarations.gms.
Good point: i checked that the bounds are not changed by the re-ordering. |
| *** 2. Emissions | ||
| *** 3. Energy System | ||
| *** 4. Other (Not fitting into the above categories or generic declarations used everywhere in the model) | ||
| *** 1. Macro-Economy |
There was a problem hiding this comment.
Thanks for fixing this! :)
Purpose of this PR
Tried to give more structure and consistency to bounds.gms.
Now it contains the following parts:
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)
/p/tmp/fabricel/bounds-refactor/202508-refactor-remind/p/tmp/fabricel/bounds-refactor/202508-refactor-remind/compScen-boundsSSP2-2025-08-15_14.09.37-H12.pdf