Skip to content

replacing deprecated nashAnalysis in favor of nashConvergenceReport - #2138

Merged
Renato-Rodrigues merged 3 commits into
remindmodel:developfrom
Renato-Rodrigues:maxSub
Jun 27, 2025
Merged

replacing deprecated nashAnalysis in favor of nashConvergenceReport#2138
Renato-Rodrigues merged 3 commits into
remindmodel:developfrom
Renato-Rodrigues:maxSub

Conversation

@Renato-Rodrigues

Copy link
Copy Markdown
Member

Purpose of this PR

  • nashAnalysis is being deprecated in favor of improved nashConvergenceReport
  • Generate a report for a Nash run, including diagnostics for key convergence criteria: trade, price incentives, emissions market targets, and quantity targets.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ◻️ GAMS Code
  • ☑️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ◻️ Refactoring
  • ☑️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):

@Renato-Rodrigues

Copy link
Copy Markdown
Member Author

pik-piam/remind2#741

@Renato-Rodrigues
Renato-Rodrigues merged commit 9b2c9fd into remindmodel:develop Jun 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants