Skip to content

Make it possible for the release to use a renv.lock - #2195

Merged
dklein-pik merged 1 commit into
remindmodel:developfrom
dklein-pik:renvForRelease
Sep 8, 2025
Merged

Make it possible for the release to use a renv.lock#2195
dklein-pik merged 1 commit into
remindmodel:developfrom
dklein-pik:renvForRelease

Conversation

@dklein-pik

@dklein-pik dklein-pik commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Purpose of this PR

Make it possible for the release (and any run) to use a renv.lock:

  • the functionality was already there in form of the cfg$renvLockFromPrecedingRun
  • to make it less specific rename cfg$renvLockFromPrecedingRun to cfg$UseThisRenvLock
  • add cfg$renvLockFromPrecedingRun to the default.cfg

Type of change

Parts concerned

  • ◻️ GAMS Code
  • ☑️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ☑️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ◻️ Refactoring
  • ☑️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

- the functionality was already there in form of the cfg$renvLockFromPrecedingRun
- to make it less specific rename cfg$renvLockFromPrecedingRun to cfg$UseThisRenvLock
- add cfg$renvLockFromPrecedingRun to the default.cfg

@LaviniaBaumstark LaviniaBaumstark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the renaming

Comment thread config/default.cfg
#### Current CES parameter and GDX revision (commit hash) ####
cfg$CESandGDXversion <- "00013a4f0071f982a549e73748e50e45a02032e8"

#### Path to a renv.lock file to restore a project's dependencies from. If NULL, all R packages in their currently installed version will be used.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, should be a configuration switch

@dklein-pik
dklein-pik marked this pull request as ready for review September 8, 2025 12:57
@dklein-pik
dklein-pik merged commit 4aecf1e into remindmodel:develop Sep 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants