Skip to content

remove input f21_max_pe_sub.cs4r - #2201

Merged
fbenke-pik merged 3 commits into
remindmodel:developfrom
fbenke-pik:maxPeSubsidy
Sep 17, 2025
Merged

remove input f21_max_pe_sub.cs4r#2201
fbenke-pik merged 3 commits into
remindmodel:developfrom
fbenke-pik:maxPeSubsidy

Conversation

@fbenke-pik

@fbenke-pik fbenke-pik commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

Purpose of this PR

This removes the input data file f21_max_pe_sub.cs4r, which has no longer any affect on the run.

The file merely defines a bound of 7.58 $/Gj for oil and gas in Japan, but according to the data in f21_tau_pe_sub.cs4r, this value is not exceeded, hence has no impact.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ☑️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ◻️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ☑️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

Comparison files can be found here

/p/tmp/benke/model/remind/compScen-SSP3-2025-09-15_15.56.57-H12.pdf
/p/tmp/benke/model/remind/compScen-SSP2-2025-09-15_13.44.49-H12.pdf
/p/tmp/benke/model/remind/compScen-SSP1-2025-09-15_11.09.10-H12.pdf

@fbenke-pik
fbenke-pik marked this pull request as ready for review September 16, 2025 09:05
*** Subsidy proportional cap to avoid liquids increasing dramatically
p21_tau_fe_sub(ttot,regi,sector,entyFe)$p21_prop_fe_sub(ttot,regi,entyFe) = p21_tau_fe_sub(ttot,regi,sector,entyFe) * p21_prop_fe_sub(ttot,regi,entyFe);
*** Maximum primary energy subsidy levels (in $/Gj) to provide plausible upper bound: 40$/barrel ~ 8 $/GJ"
p21_tau_fuEx_sub(ttot,regi,enty)$f21_max_pe_sub(ttot,regi,enty) = max(p21_tau_fuEx_sub(ttot,regi,enty),-f21_max_pe_sub(ttot,regi,enty)*0.001/sm_EJ_2_TWa);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about p21_tau_fuEx_sub? Should it also be removed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, no. This one is used in the tax module. We only remove the upper bound imposed on this parameter, as the current input data never exceeds it.

@fbenke-pik
fbenke-pik merged commit f37ef1d into remindmodel:develop Sep 17, 2025
3 checks passed
@fbenke-pik
fbenke-pik deleted the maxPeSubsidy branch September 17, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants