remove input f21_max_pe_sub.cs4r - #2201
Merged
Merged
Conversation
fbenke-pik
marked this pull request as ready for review
September 16, 2025 09:05
| *** Subsidy proportional cap to avoid liquids increasing dramatically | ||
| p21_tau_fe_sub(ttot,regi,sector,entyFe)$p21_prop_fe_sub(ttot,regi,entyFe) = p21_tau_fe_sub(ttot,regi,sector,entyFe) * p21_prop_fe_sub(ttot,regi,entyFe); | ||
| *** Maximum primary energy subsidy levels (in $/Gj) to provide plausible upper bound: 40$/barrel ~ 8 $/GJ" | ||
| p21_tau_fuEx_sub(ttot,regi,enty)$f21_max_pe_sub(ttot,regi,enty) = max(p21_tau_fuEx_sub(ttot,regi,enty),-f21_max_pe_sub(ttot,regi,enty)*0.001/sm_EJ_2_TWa); |
Member
There was a problem hiding this comment.
what about p21_tau_fuEx_sub? Should it also be removed?
Contributor
Author
There was a problem hiding this comment.
As far as I can see, no. This one is used in the tax module. We only remove the upper bound imposed on this parameter, as the current input data never exceeds it.
LaviniaBaumstark
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This removes the input data file
f21_max_pe_sub.cs4r, which has no longer any affect on the run.The file merely defines a bound of 7.58 $/Gj for oil and gas in Japan, but according to the data in
f21_tau_pe_sub.cs4r, this value is not exceeded, hence has no impact.Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)
Comparison files can be found here
/p/tmp/benke/model/remind/compScen-SSP3-2025-09-15_15.56.57-H12.pdf/p/tmp/benke/model/remind/compScen-SSP2-2025-09-15_13.44.49-H12.pdf/p/tmp/benke/model/remind/compScen-SSP1-2025-09-15_11.09.10-H12.pdf