Add new realization 11_aerosols/exoGAINS2025 by laurinks · Pull Request #2205 · remindmodel/remind

laurinks · 2025-09-17T15:21:22Z

Purpose of this PR

This PR adds a new realization 11_aerosols/exoGAINS2025 based on the input data provided by the new functions calcGAINS2025 and calcAirPollBaseyearEmi from pik-piam/mrremind#731.

! new inputdata including mrremind-PR731 is required!
! new reporting required remind2-PR753!

It implements the approach to calculate air pollutant emissions as:

Baseyear emissions (2020) * (GAINS emission factor / GAINS emission factor (2020)) * (REMIND activity / REMIND activity (2020))

The structure of exoGAINS2025 follows the existing realization exoGAINS. The initial duplication of the realization is done in the first commit "Part 1" to be able to separate it from the content changes in the following commits.

Main changes:

New emission factors from calcGAINS2025 used in REMIND (GAMS) and exoGAINS2025Airpollutants (R).
Option to choose between GAINS and CEDS for baseyear emissions in 2020 with cm_APsource
Reworking of exoGAINS2025 script to remove bugs and consistently implement new calculation (see above).
Update choice of REMIND activity variables based on feedback by @gunnar-pik .

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

☑️ GAMS Code
☑️ R-scripts
☑️ Documentation (GAMS incode documentation, comments, tutorials)
☑️ Input data / CES parameters
◻️ Tests, CI/CD (continuous integration/deployment)
☑️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
◻️ Other (please give a description)

Impact

◻️ Bug fix
☑️ Refactoring
☑️ New feature
◻️ Change of parameter values or input data (including CES parameters)
◻️ Minor change (default scenarios show only small differences)
☑️ Fundamental change of results of default scenarios (but limited to air pollutant emissions)

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.

I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
I adjusted the reporting in remind2 if and where it was needed
I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
My code follows the coding etiquette
I explained my changes within the PR, particularly in hard-to-understand areas
I checked that the in-code documentation is up-to-date
I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

Runs with these changes are running here: /p/tmp/laurinko/remind-airpollution
- Standard comparison PDF for a number of REMIND default scenarios (incl. old SSP2-NPi2025 for comparison): /p/tmp/laurinko/remind-airpollution/compScen-GAINS2025-2025-09-18_14.09.50-H12.pdf
- Detailled air pollutants: /p/tmp/laurinko/remind-airpollution/compScen-GAINS2025-2025-09-18_14.09.50-AirPollutantsDetailed.pdf
Comparison of results (what changes by this PR?):
- exoGAINS2025 run offline based on recent gdx files yields the following results at the CMIP7 harmonization sector level: emissions_by_sector_region_species.pdf
- For comparison, here are the results from the IIASA pipeline based on the July 30 ScenarioMIP submission:
  harmonisation-results_REMIND.pdf
- Double-checking SO2 emissions, CO2 emissions and PE|Coal in compScen-SSP2-NPi2025-GAINS-2025-09-17_23.04.23-H12.pdf (red: old, green/blue: new). As expected, due to usage of CEDS instead of GAINS as source, SO2 emissions are a bit higher. Also as expected, this leads to a slight decrease in coal use.

…1_aerosols

… REMIND and first half of exoGAINS2025Airpollutants script.

…uding removal of f11_emiAPexsolve.cs4r which only contains data for GAINSlegacy scenarios

LaviniaBaumstark · 2025-09-17T15:30:43Z

+                            "modules/11_aerosols/exoGAINS2025/input/emi2020_sectGAINS_sourceCEDS.cs4r",
+                            "modules/11_aerosols/exoGAINS2025/input/emifacs_sectGAINS_sourceCEDS.cs4r",
+                            "modules/11_aerosols/exoGAINS2025/input/emi2020_sectGAINS_sourceGAINS.cs4r",
+                            "modules/11_aerosols/exoGAINS2025/input/emifacs_sectGAINS_sourceGAINS.cs4r",   


why will those new data not be provided by the input data?

I followed the current logic of the exoGAINS script. These files are needed for it, and thus need to be copied into the run folder. Agree?

It seems that it can be changed. Will do.

Adressed by this commit: 2fd89d9

Is this the preferred way to implement it?

LaviniaBaumstark · 2025-09-17T15:31:24Z

    SSP4
    SSP5
+    MTFR
+    SMIPVLLO


can this be deleted as long as we keep the old exoGAins-realization?

GAINSlegacy can be deleted once we delete the old exoGAINS realization. It is not needed for the new exoGAINS2025 realization.

LaviniaBaumstark · 2025-09-17T15:37:21Z

+                        + p11_emiAPexsolve(t,regi,"solvents","BC")
+                        + p11_emiAPexsolve(t,regi,"extraction","BC")
+                        + p11_emiAPexsolve(t,regi,"indprocess","BC");
+pm_emiExog(t,regi,"OC") = p11_emiAPexo(t,regi,"OC","AgWasteBurning")


where are those data calculated for startyear > 2005?

This is old (questionable) data that I had to keep for now in the interest of time. I would be happy to delete it all right away, but do not want to crash REMIND. The data currently comes from the old mrremind functions: https://github.com/pik-piam/mrremind/blob/3770198d494e3aa49c04f673ddc03586ca4186a4/R/fullREMIND.R#L110C1-L112C123

Updating this is part of : pik-piam/mrremind#731 (comment)

LaviniaBaumstark · 2025-09-17T15:41:55Z

+emifacs_sectGAINS_sourceCEDS.cs4r
+f11_emifacs_sectREMIND_sourceCEDS.cs4r
+emi2020_sectGAINS_sourceGAINS.cs4r
+emifacs_sectGAINS_sourceGAINS.cs4r


are all emi* files generated by input data process? If so, you do not need to add those to cfg$files2export$start, Distribution would happen automatically

Yes, all emi files are generated by input data process. But how would REMIND now to put these here?

This is linked to #2205 (comment). Please let me know if the input data files should be handled differently.

…ger used

…x): Fill NAs before computing GLO emissions.

laurinks added 5 commits September 16, 2025 14:18

GAINS2025 part 1: Duplicate exoGAINS realization as exoGAINS2025 in 1…

d2b879c

…1_aerosols

GAINS2025 part 2.A: Update inputdata files, mapping from GAINS2025 to…

db60177

… REMIND and first half of exoGAINS2025Airpollutants script.

Merge branch 'develop' into GAINS2025

6bcb3c6

GAINS2025 part 2.B: Update GAMS part in 11_aerosols/exoGAINS2025 incl…

4c01e9d

…uding removal of f11_emiAPexsolve.cs4r which only contains data for GAINSlegacy scenarios

GAINS2025 part 3.A: Update exoGAINS2025AirPollutants.R

a056be3

laurinks requested a review from LaviniaBaumstark September 17, 2025 15:21

LaviniaBaumstark reviewed Sep 17, 2025

View reviewed changes

laurinks added 3 commits September 17, 2025 17:50

GAINS2025 part 3.B: Complete exoGAINS2025AirPollutants.R script

f9e0244

Avoid copying input data files and mapping to output folder

2fd89d9

Add descriptions and code check

10f3c40

laurinks requested review from gabriel-abrahao, merfort and nicobauer September 17, 2025 16:56

laurinks added 3 commits September 17, 2025 19:19

Delete PyPSA config file in agreement with Chris Gong as it is no lon…

08cc07c

…ger used

Update CHANGELOG and correct RIKEN config

4392897

Merge branch 'develop' into GAINS2025

589f217

laurinks marked this pull request as ready for review September 17, 2025 17:54

Bugfix (not affecting REMIND since GLO is dropped before export to gd…

687531a

…x): Fill NAs before computing GLO emissions.

LaviniaBaumstark approved these changes Sep 17, 2025

View reviewed changes

LaviniaBaumstark merged commit 4864efd into remindmodel:develop Sep 17, 2025
3 checks passed

laurinks deleted the GAINS2025 branch September 18, 2025 11:33

laurinks mentioned this pull request Sep 30, 2025

Air Pollutants: Clean-up and code improvements as follow-up of #731 pik-piam/mrremind#747

Merged

Uh oh!

Conversation

laurinks commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Type of change

Parts concerned

Impact

Checklist

Further information (optional)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laurinks Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

laurinks commented Sep 17, 2025 •

edited

Loading

laurinks Sep 17, 2025 •

edited

Loading