Skip to content

implement renewable share targets for NPi runs based on NewClimate protocol - #2226

Merged
fschreyer merged 15 commits into
remindmodel:developfrom
fschreyer:NpiNDC
Oct 24, 2025
Merged

implement renewable share targets for NPi runs based on NewClimate protocol#2226
fschreyer merged 15 commits into
remindmodel:developfrom
fschreyer:NpiNDC

Conversation

@fschreyer

@fschreyer fschreyer commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Purpose of this PR

This addresses https://github.com/remindmodel/development_issues/issues/438.

It adds renewable share target implementation to the NPi2025 realization of the techpol module based on new data of the NewClimate policy protocol. Targets can be switched on/off via new switch cm_RenShareTargets. By default the renewable share targets are on. It removes the hard-coded constraint of the EUR renewable share target from before.

Generally, there are only small differences in the EUR region for NPI2025 of some higher renewable shares with the targets on (see below).

Note: As a new input file is added, this PR increments the input data revision for REMIND to 7.72. Hence, this PR also introduces changes unrelated to renewable share targets to REMIND via a new set of input data. This is fine with @LaviniaBaumstark.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ☑️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ◻️ Refactoring
  • ☑️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ☑️Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):

scenario comparison with and without renewable share targets: /p/tmp/schreyer/Modeling/remind/Current/compScen-Npi_RenShareTargets-2025-10-09_09.52.29-H12-short.pdf

image image image image

@fschreyer
fschreyer requested review from RahelMA and lea-hayez October 9, 2025 12:35
@fschreyer
fschreyer marked this pull request as ready for review October 22, 2025 12:04

@RahelMA RahelMA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Felix, for that great work!

I would just like us to double-check why we don't think the NPi tech targets (incl. ren share targets) should be the default.

Comment thread modules/40_techpol/NPi2025/declarations.gms
Comment thread main.gms
)
)
;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an elegant way to solve over the four types, thank you!

Comment thread modules/40_techpol/NPi2025/sets.gms
@fschreyer
fschreyer requested a review from RahelMA October 24, 2025 10:24

@RahelMA RahelMA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes; it looks good to me now! Maybe in another PR, we should set NPi2025 as default for techpol!

@fschreyer

Copy link
Copy Markdown
Contributor Author

Ok nice! It is already default here. ;-)

@fschreyer
fschreyer merged commit 673a0e3 into remindmodel:develop Oct 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants