implement renewable share targets for NPi runs based on NewClimate protocol - #2226
Merged
Conversation
added 7 commits
June 13, 2025 11:45
…l module realization NPI2025
…025 and switch on renewable share targets in this realization by default using c40_RenShareTargets = 1
added 7 commits
October 21, 2025 12:01
…rgest from declarations to sets file
fschreyer
marked this pull request as ready for review
October 22, 2025 12:04
RahelMA
requested changes
Oct 23, 2025
RahelMA
left a comment
Contributor
There was a problem hiding this comment.
Thank you, Felix, for that great work!
I would just like us to double-check why we don't think the NPi tech targets (incl. ren share targets) should be the default.
| ) | ||
| ) | ||
| ; | ||
|
|
Contributor
There was a problem hiding this comment.
That's an elegant way to solve over the four types, thank you!
RahelMA
approved these changes
Oct 24, 2025
RahelMA
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick changes; it looks good to me now! Maybe in another PR, we should set NPi2025 as default for techpol!
Contributor
Author
|
Ok nice! It is already default here. ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This addresses https://github.com/remindmodel/development_issues/issues/438.
It adds renewable share target implementation to the NPi2025 realization of the techpol module based on new data of the NewClimate policy protocol. Targets can be switched on/off via new switch
cm_RenShareTargets. By default the renewable share targets are on. It removes the hard-coded constraint of the EUR renewable share target from before.Generally, there are only small differences in the EUR region for NPI2025 of some higher renewable shares with the targets on (see below).
Note: As a new input file is added, this PR increments the input data revision for REMIND to 7.72. Hence, this PR also introduces changes unrelated to renewable share targets to REMIND via a new set of input data. This is fine with @LaviniaBaumstark.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)
scenario comparison with and without renewable share targets:
/p/tmp/schreyer/Modeling/remind/Current/compScen-Npi_RenShareTargets-2025-10-09_09.52.29-H12-short.pdf