Skip to content

remove no longer used technologies - #2228

Merged
fbenke-pik merged 4 commits into
remindmodel:developfrom
fbenke-pik:refactor
Oct 17, 2025
Merged

remove no longer used technologies#2228
fbenke-pik merged 4 commits into
remindmodel:developfrom
fbenke-pik:refactor

Conversation

@fbenke-pik

@fbenke-pik fbenke-pik commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

Purpose of this PR

Remove no longer used technologies pcc, pco, apCarPeT, which were still kept because they were still in the input data. The have been removed from inputdata pik-piam/mrremind#753

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ☑️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ☑️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ☑️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):

@fbenke-pik

Copy link
Copy Markdown
Contributor Author

@LaviniaBaumstark let me know once you created new input data. This should be merged once new input data incorporating the linked mrremind PR is used in REMIND.

@fbenke-pik fbenke-pik changed the title Refactor remove no longer used transport technologies Oct 17, 2025
@fbenke-pik fbenke-pik changed the title remove no longer used transport technologies remove no longer used technologies Oct 17, 2025
@fbenke-pik
fbenke-pik marked this pull request as ready for review October 17, 2025 12:33
@fbenke-pik
fbenke-pik merged commit 23a31b3 into remindmodel:develop Oct 17, 2025
5 checks passed
@fbenke-pik
fbenke-pik deleted the refactor branch October 17, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants