Skip to content

remove buildings entries from sets.gms - #2230

Merged
fbenke-pik merged 8 commits into
remindmodel:developfrom
fbenke-pik:refactor
Nov 10, 2025
Merged

remove buildings entries from sets.gms#2230
fbenke-pik merged 8 commits into
remindmodel:developfrom
fbenke-pik:refactor

Conversation

@fbenke-pik

@fbenke-pik fbenke-pik commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

Purpose of this PR

Delete no longer used buildings items from sets.gms. They were just kept due to compilation errors when still present in the input data.

Related mrremind PR: pik-piam/mrremind#758

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ☑️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ☑️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ◻️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ☑️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):

@fbenke-pik
fbenke-pik marked this pull request as ready for review October 30, 2025 09:49
@fbenke-pik
fbenke-pik requested a review from robinhasse October 30, 2025 09:50

@robinhasse robinhasse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Falk! I assume, the items have been removed from the input data used in the current version already? Otherwise you would still have to increment the input data revision.

@fbenke-pik

Copy link
Copy Markdown
Contributor Author

Yes, please check the related mrremind PR: pik-piam/mrremind#758

@fbenke-pik
fbenke-pik merged commit ffc2655 into remindmodel:develop Nov 10, 2025
2 checks passed
@fbenke-pik
fbenke-pik deleted the refactor branch November 10, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants