AP in REMIND - exoGAINS2025 - part 1: Move exoGAINS2025Airpollutants.R from REMIND to remind2 by laurinks · Pull Request #2231 · remindmodel/remind

laurinks · 2025-10-23T15:17:44Z

Purpose of this PR

This PR needs to be merged together with pik-piam/remind2#768 and before pik-piam/mrremind#761 .

It addresses https://github.com/remindmodel/development_issues/issues/675

Remove exoGAINS2025Airpollutants.R and related code in 11_aerosols/exoGAINS2025.
Move sets from core to 11_aerosols.
Make mrremind files available for remind2 reporting.

Follow-up PR in piamInterfaces needed to update names of air pollutant emission variables accordingly.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

☑️ GAMS Code
☑️ R-scripts
◻️ Documentation (GAMS incode documentation, comments, tutorials)
◻️ Input data / CES parameters
◻️ Tests, CI/CD (continuous integration/deployment)
◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
◻️ Other (please give a description)

Impact

◻️ Bug fix
☑️ Refactoring
◻️ New feature
◻️ Change of parameter values or input data (including CES parameters)
◻️ Minor change (default scenarios show only small differences)
◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.

I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
I adjusted the reporting in remind2 if and where it was needed
I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
My code follows the coding etiquette
I explained my changes within the PR, particularly in hard-to-understand areas
I checked that the in-code documentation is up-to-date
I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

Runs with these changes are here: /p/tmp/laurinko/airpollution-restructuring
Comparison of results (what changes by this PR?): No changes.

… for remind2 reporting

…emind2.

laurinks · 2025-12-22T15:04:04Z

It is no longer necessary to copy the exoGAINS script and the input data into the REMIND output folder since (a) the calculation of AP emissions is moved to remind2, and (b) the files are made available via core/input/reporting/files.

laurinks · 2025-12-22T15:07:11Z

As exogenous AP emissions are no longer piped through REMIND, no values are assigned pm_emiExog and it can be removed from this equation.

laurinks · 2025-12-22T15:08:02Z

 c_model_version  "model version" /%c_model_version%/
 cm_GDPpopScen    "cm_GDPpopScen as set for use in GDX"      /%cm_GDPpopScen%/
-
+cm_APssp         "cm_APssp as set for use in GDX"           /%cm_APssp%/


Needed for remind2::reportAirPollutantEmissions

laurinks · 2025-12-22T16:26:03Z


 /

-all_sectorEmi "all sectors with emissions"


Moved to 11_aerosols

laurinks · 2025-12-22T16:26:11Z

-    waste        "emissions from waste"
-/
-
-all_exogEmi "all exogenous emission types"


No longer needed

laurinks · 2025-12-22T16:28:01Z

    ch4gas     "fugitive emissions from gas production"
    ch4oil     "fugitive emissions from oil production"
 /
-sectorEndoEmi(all_sectorEmi)   "sectors with endogenous emissions"


Moved to 11_aerosols

laurinks · 2025-12-22T16:28:08Z

-    trans    "transport"
-    power    "power"
-/
-sectorExogEmi(all_sectorEmi) "sectors with exogenous emissions"


Moved to 11_aerosols

laurinks · 2025-12-22T16:28:14Z

    2005.1
 /

-sectorEndoEmi2te(all_enty,all_enty,all_te,sectorEndoEmi)   "map sectors to technologies"


Moved to 11_aerosols

laurinks · 2025-12-22T16:29:13Z

Exogenous AP emssions no longer piped through REMIND but directly read in remind2::reportAirPollutantEmissions

laurinks · 2025-12-22T16:29:41Z

Moved to remind2.

laurinks · 2025-12-22T16:31:38Z

exoGAINS2025AirPollutants was running in the postsolve without feeding information into the next iteration, i.e. with not effect on the model. Thus, it now only runs in remind2. This means that for normal runs, it is only executed once, while for runs with climate assessment in between iterations, it is called via remind2::reportEmiforClimateAssessment.

…eeded

merfort

Great, thanks a lot, @laurinks!

laurinks added 3 commits October 23, 2025 15:56

Make air pollutant emission factors and base year emissions available…

898eee1

… for remind2 reporting

Remove exoGAINS2025Airpollutants.R from REMIND. It will be added in r…

3506c0a

…emind2.

Move sets from core to 11_aerosols

1ff0ebc

laurinks changed the title ~~Airpollution restructuring~~ AP in REMIND - exoGAINS2025 - part 1: Move exoGAINS2025Airpollutants.R from REMIND to remind2 Oct 23, 2025

laurinks added 2 commits October 24, 2025 17:30

reportAirPollutantEmissions requires AP compiler flags

e95e562

Merge branch 'develop' into airpollution-restructuring

98b2bb4

laurinks mentioned this pull request Dec 19, 2025

Airpollution restructuring pik-piam/remind2#768

Merged

2 tasks

Merge branch 'develop' into airpollution-restructuring

9f38fc3

laurinks commented Dec 22, 2025

View reviewed changes

Comment thread core/sets.gms

/

all_sectorEmi "all sectors with emissions"

laurinks Dec 22, 2025

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to 11_aerosols

laurinks commented Dec 22, 2025

View reviewed changes

Comment thread modules/11_aerosols/exoGAINS2025/input/mappingGAINS2025toREMIND.csv

laurinks Dec 22, 2025

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to remind2.

laurinks commented Dec 22, 2025

View reviewed changes

Add comment to CHANGELOG

5fcb559

laurinks requested review from LaviniaBaumstark, dklein-pik and fbenke-pik and removed request for LaviniaBaumstark December 22, 2025 16:37

laurinks marked this pull request as ready for review December 22, 2025 16:39

laurinks mentioned this pull request Dec 22, 2025

Air Pollutant Restructuring pik-piam/mrremind#761

Merged

laurinks requested a review from merfort December 23, 2025 10:58

merfort reviewed Dec 23, 2025

View reviewed changes

Comment thread modules/11_aerosols/exoGAINS2025/sets.gms Outdated

merfort reviewed Dec 23, 2025

View reviewed changes

Comment thread modules/11_aerosols/exoGAINS2025/sets.gms Outdated

Add module suffix to sets in 11_aerosols and remove set that is not n…

7c09be5

…eeded

merfort self-requested a review December 23, 2025 15:46

merfort reviewed Dec 23, 2025

View reviewed changes

Comment thread modules/11_aerosols/exoGAINS2025/declarations.gms Outdated

merfort approved these changes Dec 23, 2025

View reviewed changes

Code etiquette adjustments

4975902

laurinks merged commit 3dfee20 into remindmodel:develop Dec 24, 2025
2 checks passed

laurinks deleted the airpollution-restructuring branch December 24, 2025 09:02

Uh oh!

Conversation

laurinks commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Type of change

Parts concerned

Impact

Checklist

Further information (optional)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laurinks Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

merfort left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

laurinks commented Oct 23, 2025 •

edited

Loading

laurinks Dec 22, 2025 •

edited

Loading