Rewriting 46/netZero - #2307
Conversation
…d of nocc_hist)" This reverts commit c99a4f5.
RahelMA
left a comment
There was a problem hiding this comment.
Thank you, Fabrice, for cleaning the 46 module! It looks really nice now!
Overall I have just some minor comments (e.g., I noticed little errors I introduced)...
Maybe you can provide some description of the difference of cm_netZeroScen? Do I understand it correctly, that the ELEVATE offset calculation is now the new default? And we only have two divergences:
- ELEVATE with 100 offset in EUR
- NGFS 20% reduction?
Would be helpful to have this overall description maybe in the realization, what do you think?
fschreyer
left a comment
There was a problem hiding this comment.
Hey, unfortunately I am not really familiar with this module.
Thanks for all typo corrections etc.
I adapted one of the descriptions. Hope that worked.
This comment was marked as resolved.
This comment was marked as resolved.
| *' pm_taxCO2eqRegi grows linearly from zero in cm_LTSstartYr to p46_taxCO2eqRegiInitial in the target year, then back toward zero in 2200. | ||
| p46_taxCO2eqRegiInitial = 100 * sm_DptCO2_2_TDpGtC; !! [$/tCO2 converted to T$/GtC] | ||
| loop((regi,t,targetSpecies) $ p46_netZeroTargetCoverage(regi,t,targetSpecies), | ||
| pm_taxCO2eqRegi(t2,regi) $ (cm_LTSstartYr <= t2.val and t2.val <= t.val) = macro_interpolate(t2.val, cm_LTSstartYr-5, t.val, 0, p46_taxCO2eqRegiInitial); |
There was a problem hiding this comment.
I'm a bit confused we now only use cm_LTSstartYr for pm_taxCO2eqRegi, do I understand it correctly that we don't need this in postsolve for calculating the mark-up as we only initialize it here?
There was a problem hiding this comment.
No, the algorithm only rescales the markup at the target year. Then the shape is fixed, going up linearly from cm_LTSstartYr to the target year, and down again until the (future) switch cm_LTSendYr if activated
… $ (card can apparently not do that)
…ape is applied for other years
This reverts commit 9a8da70.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)