Allow scenario aliases in compareScenarios2 - #2399
Merged
simonkrogmann merged 2 commits intoJul 14, 2026
Merged
Conversation
fbenke-pik
reviewed
Jul 13, 2026
fbenke-pik
reviewed
Jul 13, 2026
fbenke-pik
reviewed
Jul 13, 2026
fbenke-pik
reviewed
Jul 13, 2026
fbenke-pik
reviewed
Jul 13, 2026
simonkrogmann
force-pushed
the
scenario-aliases
branch
2 times, most recently
from
July 14, 2026 08:43
3b31fdb to
5246537
Compare
fbenke-pik
reviewed
Jul 14, 2026
| if (!exists("outputdir")) { | ||
| aliases = promptForAliases(outputdirs, aliases) | ||
| } | ||
| if (exists("aliases")) |
Contributor
There was a problem hiding this comment.
Please use autoindent do make sure this is indented correctly.
fbenke-pik
approved these changes
Jul 14, 2026
simonkrogmann
force-pushed
the
scenario-aliases
branch
3 times, most recently
from
July 14, 2026 14:01
f22283a to
7f75082
Compare
simonkrogmann
force-pushed
the
scenario-aliases
branch
from
July 14, 2026 14:04
7f75082 to
09cf6ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
If compareScenarios2 is started with runs that are based on the same scenario (e.g. default), they will have almost the same name in the resulting pdf (default.1, default.2), which makes comparing difficult. Now users are prompted for aliases if there are identical scenario names. For scripting backwards compatibility this only happens if the runs are selected manually. piamPlotComparison already offers a corresponding feature so no change is necessary there.
Other comparison modules may also make use of these aliases, but I have neither implemented not tested them, because I don't know which modules are still in use.
Please give lots of feedback, also about R conventions and functions, I'm learning it at the moment.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)