Wrapping the Rust MatchSpec in Python#16
Merged
remkade merged 4 commits intoremkade:mainfrom Nov 10, 2022
Merged
Conversation
8e8d038 to
69bba1d
Compare
marcoesters
reviewed
Nov 10, 2022
remkade
reviewed
Nov 10, 2022
Owner
remkade
left a comment
There was a problem hiding this comment.
Not sure how maturin likes to handle errors, but maybe this will work?
Comment on lines
11
to
14
| fn match_against_matchspec(matchspec: String, package: String, version: String) -> bool { | ||
| let ms: matchspec::MatchSpec<String> = matchspec.parse(); | ||
| ms.is_package_version_match(&package, &version) | ||
| } |
Owner
There was a problem hiding this comment.
Maybe the correct way to do this is by returning a PyResult? That way we don't lose the possible error. Maybe this?
Suggested change
| fn match_against_matchspec(matchspec: String, package: String, version: String) -> bool { | |
| let ms: matchspec::MatchSpec<String> = matchspec.parse(); | |
| ms.is_package_version_match(&package, &version) | |
| } | |
| fn match_against_matchspec(matchspec: String, package: String, version: String) -> PyResult<bool> { | |
| let ms: matchspec::MatchSpec<String> = matchspec.parse()?; | |
| Ok(ms.is_package_version_match(&package, &version)) | |
| } |
That question mark after the parse() will return the error if there is one, otherwise will unwrap the Ok(MatchSpec<String>) and give just the MatchSpec<String>.
Collaborator
Author
There was a problem hiding this comment.
I tried using unwrap() as suggested by @marcoesters (suggestion was made outside of this PR) and it seems to work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses this issue:
To run this, enter the following command from the directory where the
matchspec_in_rust.pyis located: