Round 2 Roast: 10 Findings Fixed
Regression (1)
- Version mismatch: init.py, pyproject.toml, README all synced to 2.3.1
HIGH Priority (3)
- StreamingAnomalyDetector.reset() now resets scaler
- StreamingAnomalyDetector lazy retraining (every 10th sample, not every sample)
- battery_scoring.py: errors logged instead of returning 100.0 (was silently masking failures)
MEDIUM Priority (2)
- analyze_telemetry: min sample guard (10 samples minimum)
- Removed module-level assert in battery_scoring.py (replaced with runtime ValueError)
LOW Priority (4)
- Removed warning suppression in fleet_analytics.py
- Dashboard defaults to 127.0.0.1 (not 0.0.0.0)
- Added logging to shutdown handler
- Fixed all module-level asserts
Test Results
980 tests passing, 0 failures
Total Roast Progress
- Round 1: 27/27 findings fixed
- Round 2: 10/10 findings fixed
- Grand total: 37/37 findings fixed