allow serving multiple public domains #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bin-ario
force-pushed
the
bin/auth
branch
2 times, most recently
from
9607627 to
c6ecd8c
Compare
bin-ario
changed the title
bin-ario
commented
Dec 16, 2025
Comment on lines
-53
to
+55
| if request.url.path.startswith("/mcp"): # type: ignore | ||
| # Store all incoming headers in context for access during request | ||
| incoming_headers_context.set(dict(request.headers)) | ||
| incoming_headers_context.set(dict(request.headers)) |
Contributor
Author
There was a problem hiding this comment.
we want to get the request headers for all requests for get_server_origin, not just mcp requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we want to access the server at different domains. to do so, we need to handle oauth separately for individual domains.
the new
SERVER_CONFIGSconfigs a set of domains, each with a list of auth providersthe implementation here starts separate uvicorn servers, each is responsible for a domain, so that the oauth is handled separately. when receiving a request,
get_server_originhelper gets the domain the client is requesting, so we invoke the right auth flow accordinglyall uvicorn servers share the same ContainerManager