fix(money) - parse values before prettifying#1001
Merged
gabrielseco merged 10 commits intomainfrom May 8, 2026
Merged
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (312 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 49f0df8. Configure here.
gabrielseco
commented
May 6, 2026
gabrielseco
commented
May 6, 2026
gabrielseco
commented
May 6, 2026
gabrielseco
commented
May 6, 2026
gabrielseco
commented
May 6, 2026
gabrielseco
commented
May 6, 2026
gabrielseco
commented
May 6, 2026
cammellos
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The problem
When users use the onboarding for Belgium, the contract details has some fields like eco_voucher and yearly premium rendered incorrectly
The solution
The solution is to pass to prettifyFormValues in the onSubmit, the values already parsed and that way in prettifyFormValues we can convert always trusting that the input will be always in cents
the problem was the values of the form was mixing cents && normal values in different inputs
We builld a escape hatch when we call prettifyFormValues when an employee has been invited
https://www.loom.com/share/2efa29079483435f8c160faef9a7ba81
Note
Medium Risk
Touches shared form value transformation and review metadata rendering, which can affect how money amounts and some field values are displayed across multiple flows. Main risk is incorrect unit conversion (cents vs. major units) in review screens or tests if any step bypasses the new parsing/prettifying order.
Overview
Review metadata now uses parsed values (API-shaped) when calling
prettifyFormValuesinOnboarding,ContractorOnboarding,CreateCompany, andCostCalculator, preventing mismatches between what is submitted and what is shown in the review/meta UI.Money prettification is corrected:
prettifyFormValuesnow convertsmoneyvalues from cents viaconvertFromCents, supportsnull, and adds an optionskipMoneyConversionused when building review metadata from initial (already-normalized) values during auto-navigation to review.UI/test updates: review step rendering is adjusted to hide empty
engagement_agreement_details, introduces a sharedPrettifiedValuesRendererfor tests, and adds/updates tests to assert correct money display in review (including direct-to-review invited employments).Reviewed by Cursor Bugbot for commit e368313. Bugbot is set up for automated code reviews on this repo. Configure here.