Skip to content

fix(contractor-onboarding) - fix eor card appear when subscriptions returned by BE less than 3#1015

Merged
gabrielseco merged 3 commits into
mainfrom
correct-logic-contractor-subscriptions
May 14, 2026
Merged

fix(contractor-onboarding) - fix eor card appear when subscriptions returned by BE less than 3#1015
gabrielseco merged 3 commits into
mainfrom
correct-logic-contractor-subscriptions

Conversation

@gabrielseco
Copy link
Copy Markdown
Collaborator

@gabrielseco gabrielseco commented May 14, 2026

When the subscriptions is less than 3 hardcoded yes. we make the contractor onboarding card to appear

Note

Medium Risk
Changes the decision logic that controls which subscription options (including EOR) are shown during contractor onboarding, which can affect user plan selection and downstream onboarding flow. Risk is limited to UI/business logic with no auth or data model changes.

Overview
Fixes the contractor onboarding pricing-plan step so the subscription field options are built from a memoized, consistently filtered subscription list and returned as filteredContractorSubscriptions.

Updates the EOR option visibility logic to key off a “missing subscriptions” threshold (max 3) and eligibility-questionnaire blocking, and explicitly suppresses EOR when excludeProducts includes eor, while keeping the option grouping/separator behavior intact.

Reviewed by Cursor Bugbot for commit 4cdaa34. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 211.62 kB 211.58 kB +33 B (+0.0%) 🔴
Total (raw) 573.01 kB 572.93 kB +87 B (+0.0%) 🔴
CSS (gzip) 20.86 kB 20.86 kB 0 B (0%) 🟢
CSS (raw) 108.83 kB 108.83 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 211.62 kB / 250 kB (84.6%)
  • ✅ Total raw: 573.01 kB / 600 kB (95.5%)
  • ✅ CSS gzipped: 20.86 kB / 25 kB (83.4%)

Largest Files (Top 5)

  1. chunk-5BU3CD2P.js - 14 kB (0 B (0%))
  2. styles.css - 10.43 kB (0 B (0%))
  3. index.css - 10.43 kB (0 B (0%))
  4. index.js - 6.1 kB (+1 B (+0.0%))
  5. chunk-TNQKP2XT.js - 5.89 kB (0 B (0%))
View All Files (312 total)
File Size (gzip) Change
chunk-5BU3CD2P.js 14 kB 0 B (0%)
styles.css 10.43 kB 0 B (0%)
index.css 10.43 kB 0 B (0%)
index.js 6.1 kB +1 B (+0.0%)
chunk-TNQKP2XT.js 5.89 kB 0 B (0%)
chunk-7AQ7V57P.js 5.81 kB 0 B (0%)
chunk-JXAAON7I.js 5.26 kB 0 B (0%)
chunk-J4NCN3TG.js 4.62 kB 0 B (0%)
chunk-LWUYXRRG.js 4.38 kB new
chunk-72K4C6OR.js 4.06 kB 0 B (0%)

✅ Bundle size check passed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 89.99% 89.99% 0%
Statements 89.66% 89.66% 0%
Functions 87.71% 87.70% +0.01% 🟢
Branches 80.04% 80.02% +0.01% 🟢

Detailed Breakdown

Lines Coverage
  • Covered: 3678 / 4087
  • Coverage: 89.99%
  • Change: 0% (1 lines)
Statements Coverage
  • Covered: 3739 / 4170
  • Coverage: 89.66%
  • Change: 0% (1 statements)
Functions Coverage
  • Covered: 999 / 1139
  • Coverage: 87.71%
  • Change: +0.01% (1 functions)
Branches Coverage
  • Covered: 2285 / 2855
  • Coverage: 80.04%
  • Change: +0.01% (2 branches)

✅ Coverage check passed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-axy7npx0v-remotecom.vercel.app
Latest Commit:4cdaa34
Inspect:View deployment

Deployed with vercel-action

@gabrielseco gabrielseco changed the title fix(contractor-onboarding) - fix logic fix(contractor-onboarding) - fix eor card appear when subscriptions returned by BE less than 3 May 14, 2026
@gabrielseco gabrielseco self-assigned this May 14, 2026
@gabrielseco gabrielseco merged commit a6e4995 into main May 14, 2026
10 checks passed
@gabrielseco gabrielseco deleted the correct-logic-contractor-subscriptions branch May 14, 2026 14:54
@gabrielseco gabrielseco mentioned this pull request May 14, 2026
jordividaller pushed a commit that referenced this pull request May 15, 2026
…eturned by BE less than 3 (#1015)

* fix(contractor-onboarding) - fix logic

* fix

* revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants