fix(contractor-onboarding) - fix eor card appear when subscriptions returned by BE less than 3#1015
Merged
Merged
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (312 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
cammellos
approved these changes
May 14, 2026
Merged
jordividaller
pushed a commit
that referenced
this pull request
May 15, 2026
…eturned by BE less than 3 (#1015) * fix(contractor-onboarding) - fix logic * fix * revert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the subscriptions is less than 3 hardcoded yes. we make the contractor onboarding card to appear
Note
Medium Risk
Changes the decision logic that controls which subscription options (including EOR) are shown during contractor onboarding, which can affect user plan selection and downstream onboarding flow. Risk is limited to UI/business logic with no auth or data model changes.
Overview
Fixes the contractor onboarding pricing-plan step so the
subscriptionfield options are built from a memoized, consistently filtered subscription list and returned asfilteredContractorSubscriptions.Updates the EOR option visibility logic to key off a “missing subscriptions” threshold (max 3) and eligibility-questionnaire blocking, and explicitly suppresses EOR when
excludeProductsincludeseor, while keeping the option grouping/separator behavior intact.Reviewed by Cursor Bugbot for commit 4cdaa34. Bugbot is set up for automated code reviews on this repo. Configure here.