fix: datepicker dropdown navigation + JSF logging + build heap#1134
Merged
Conversation
Add captionLayout="dropdown" with year range derived from min/max date constraints. Fix defaultMonth to follow the current field value rather than always jumping to minDate. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Pass muteLogging: true to suppress the generic remote-json-schema-form-kit noise; forward any warnings to console.warn so they remain actionable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Prevents OOM on larger bundles during tsup builds. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c7410cb. Configure here.
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (341 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report
|
| Metric | Current | Previous | Change | Status |
|---|---|---|---|---|
| Lines | 88.39% | 88.42% | -0.03% | 🔴 |
| Statements | 87.80% | 87.83% | -0.03% | 🔴 |
| Functions | 84.72% | 84.88% | -0.16% | 🔴 |
| Branches | 79.75% | 79.70% | +0.05% | 🟢 |
Detailed Breakdown
Lines Coverage
- Covered: 3845 / 4350
- Coverage: 88.39%
- Change: -0.03% (3 lines)
Statements Coverage
- Covered: 3906 / 4449
- Coverage: 87.80%
- Change: -0.03% (3 statements)
Functions Coverage
- Covered: 1042 / 1230
- Coverage: 84.72%
- Change: -0.16% (-2 functions)
Branches Coverage
- Covered: 2414 / 3027
- Coverage: 79.75%
- Change: +0.05% (11 branches)
✅ Coverage check passed
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
…n range If minDate is after currentYear + 10, or if maxDate is before minDate, the year select would have an empty or inverted range. Math.max(fromYear, ...) ensures the dropdown always includes at least the minimum year. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jordividaller
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standalone infrastructure improvements, no new flows.
muteLogging: truetomodify()to suppress generic library noise; forward any returned warnings toconsole.warnso they remain actionable.tsupbuilds to prevent OOM on larger bundles.captionLayout="dropdown"with year range derived frommin/maxdateconstraints. The arrow-only navigation is impractical for fields like date of birth where
the valid range spans decades — a dropdown lets users jump directly to the right year.
Also fix
defaultMonthto follow the current field value rather than always jumping tominDate.Add CSS for the unstyled month/year select elements that the dropdown mode relies on.
Test plan
minDate)npm run ci— should pass cleanlyNote
Low Risk
UX, logging, and build tooling changes with no auth, security, or data-path modifications.
Overview
Date picker fields now use month/year dropdown navigation instead of arrow-only paging, with
fromYear/toYearderived fromminDate/maxDate(or sensible defaults). Opening the calendar uses the current value’s month when set, otherwisemaxDateorminDate—fixing the prior behavior that always opened onminDate. Global CSS styles the react-day-picker dropdown selects used by that layout.Headless form setup passes
muteLogging: trueintomodify()and logs returnedjsfModify warningsviaconsole.warnso schema issues stay visible without library noise.Production
buildsetsNODE_OPTIONS='--max-old-space-size=8192'(matching dev) to reduce OOM risk duringtsup.Reviewed by Cursor Bugbot for commit 7c5376b. Bugbot is set up for automated code reviews on this repo. Configure here.