fix(contractor-of-record) - fix submission contract-details#932
fix(contractor-of-record) - fix submission contract-details#932gabrielseco merged 8 commits intomainfrom
Conversation
|
bugbot run |
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (310 total)
✅ Bundle size check passed |
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
|
Deploy preview for remote-flows-example-app ready! ✅ Preview Built with commit 40cf630. |
|
Deploy preview for remote-flows ready! ✅ Preview Built with commit 40cf630. |
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3b1a698. Configure here.

The switcher wasn't implemented correctly as it made the impression that it worked but it wasn't...
Had to fix that to expose a value property, then fix a reference bug on the useEffect, abstracted to implement later in Onboarding for example and also added tests to catch these problems
Note
Medium Risk
Touches core form rendering and change-watching behavior; controlled-prop changes can break existing custom components and subtly affect when
checkFieldUpdatesfires (now deep-equal based).Overview
Custom JSF field components are now treated as controlled:
JSFCustomComponentPropsgains a requiredvalue, and bothJSONSchemaFormFieldsandFieldSetFieldpassvalue={watch(...)}while keepingsetValue(...)callbacks. This fixes UI elements like the Contractor OnboardingSwitcher(Tabs) that previously looked selectable but didn’t reliably reflect/persist the current selection.Contractor Onboarding form state syncing is refactored into a new
useJSONSchemaFormhook, replacing the inlinewatch/useEffectchange-detection logic with deep-equality based updates tocheckFieldUpdates. Tests for custom components were rewritten/expanded to covervaluepropagation, updates, accessibility (aria-pressed), and behavior both at root level and inside fieldsets.Reviewed by Cursor Bugbot for commit 40cf630. Bugbot is set up for automated code reviews on this repo. Configure here.