Skip to content

feat(onboarding) - add engagement form for Germany#946

Merged
gabrielseco merged 27 commits intomainfrom
engagement-form-ii
Apr 23, 2026
Merged

feat(onboarding) - add engagement form for Germany#946
gabrielseco merged 27 commits intomainfrom
engagement-form-ii

Conversation

@gabrielseco
Copy link
Copy Markdown
Collaborator

@gabrielseco gabrielseco commented Apr 20, 2026

I added a new step that we load when the the feature flag for steps is used, added tests to cover save the form, retrieve data, render schema


Note

Medium Risk
Adds a new dynamic onboarding step with new schema/data fetches and a dedicated update mutation, which can affect step inclusion/navigation and form submission behavior for Germany flows.

Overview
Adds a new engagement_agreement_details step to the onboarding flow (wired through OnboardingFlow components and the main useOnboarding hook) that can be dynamically included based on whether the country-specific schema returns fields.

Introduces new API hooks to fetch the engagement agreement schema and any previously-saved details, plus a new mutation to persist the step via the /engagement-agreement-details endpoint; submission/validation/loading/meta/initial-values logic is updated to incorporate this step.

Updates the example app to render the new step, show a Germany-specific title/description with a Zendesk “Learn more” link, and include the step in the review UI; adds Germany to country fixtures and adds integration tests covering schema load, value prefill, and saving/navigation for Germany with dynamic_steps.

Reviewed by Cursor Bugbot for commit 994967e. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 89.90% 89.85% +0.05% 🟢
Statements 89.57% 89.52% +0.06% 🟢
Functions 87.54% 87.39% +0.16% 🟢
Branches 79.97% 79.89% +0.08% 🟢

Detailed Breakdown

Lines Coverage
  • Covered: 3633 / 4041
  • Coverage: 89.90%
  • Change: +0.05% (56 lines)
Statements Coverage
  • Covered: 3694 / 4124
  • Coverage: 89.57%
  • Change: +0.06% (56 statements)
Functions Coverage
  • Covered: 991 / 1132
  • Coverage: 87.54%
  • Change: +0.16% (14 functions)
Branches Coverage
  • Covered: 2252 / 2816
  • Coverage: 79.97%
  • Change: +0.08% (39 branches)

✅ Coverage check passed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 209.89 kB 208.42 kB +1.47 kB (+0.7%) 🔴
Total (raw) 563.39 kB 558.14 kB +5.25 kB (+0.9%) 🔴
CSS (gzip) 20.03 kB 20.03 kB 0 B (0%) 🟢
CSS (raw) 103.23 kB 103.23 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 209.89 kB / 250 kB (84.0%)
  • ✅ Total raw: 563.39 kB / 600 kB (93.9%)
  • ✅ CSS gzipped: 20.03 kB / 25 kB (80.1%)

Largest Files (Top 5)

  1. chunk-72RFYT5Y.js - 13.83 kB (0 B (0%))
  2. index.css - 10.01 kB (0 B (0%))
  3. styles.css - 10.01 kB (0 B (0%))
  4. index.js - 6.06 kB (0 B (0%))
  5. chunk-TNQKP2XT.js - 5.89 kB (new)
View All Files (313 total)
File Size (gzip) Change
chunk-72RFYT5Y.js 13.83 kB 0 B (0%)
index.css 10.01 kB 0 B (0%)
styles.css 10.01 kB 0 B (0%)
index.js 6.06 kB 0 B (0%)
chunk-TNQKP2XT.js 5.89 kB new
chunk-UTXYUM6O.js 5.81 kB new
chunk-IT5PQWVR.js 4.5 kB new
chunk-CWF26ZF4.js 4.23 kB new
chunk-DJPDKTA2.js 4.06 kB new
chunk-O4I5IA24.js 3.73 kB new

✅ Bundle size check passed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Deploy preview for remote-flows-example-app ready!

✅ Preview
https://remote-flows-example-6rjxhzw30-remotecom.vercel.app

Built with commit 80e1f07.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-8th0330eh-remotecom.vercel.app
Latest Commit:994967e
Inspect:View deployment

Deployed with vercel-action

@gabrielseco
Copy link
Copy Markdown
Collaborator Author

bugbot run

Comment thread src/flows/Onboarding/hooks.tsx
@gabrielseco gabrielseco marked this pull request as ready for review April 22, 2026 10:26
@gabrielseco
Copy link
Copy Markdown
Collaborator Author

bugbot run

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit f69268b. Configure here.

@gabrielseco gabrielseco self-assigned this Apr 22, 2026
@gabrielseco gabrielseco changed the title Engagement form ii feat(onboarding) - add engagement form for Germany Apr 22, 2026
@gabrielseco gabrielseco requested a review from cammellos April 23, 2026 06:48
@gabrielseco gabrielseco merged commit 06714f6 into main Apr 23, 2026
10 checks passed
@gabrielseco gabrielseco deleted the engagement-form-ii branch April 23, 2026 09:22
@gabrielseco gabrielseco mentioned this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants