feat(onboarding) - add engagement form for Germany#946
Merged
gabrielseco merged 27 commits intomainfrom Apr 23, 2026
Merged
Conversation
…engagement-form-ii
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (313 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for remote-flows-example-app ready! ✅ Preview Built with commit 80e1f07. |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Collaborator
Author
|
bugbot run |
Collaborator
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f69268b. Configure here.
cammellos
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new step that we load when the the feature flag for steps is used, added tests to cover save the form, retrieve data, render schema
Note
Medium Risk
Adds a new dynamic onboarding step with new schema/data fetches and a dedicated update mutation, which can affect step inclusion/navigation and form submission behavior for Germany flows.
Overview
Adds a new
engagement_agreement_detailsstep to the onboarding flow (wired throughOnboardingFlowcomponents and the mainuseOnboardinghook) that can be dynamically included based on whether the country-specific schema returns fields.Introduces new API hooks to fetch the engagement agreement schema and any previously-saved details, plus a new mutation to persist the step via the
/engagement-agreement-detailsendpoint; submission/validation/loading/meta/initial-values logic is updated to incorporate this step.Updates the example app to render the new step, show a Germany-specific title/description with a Zendesk “Learn more” link, and include the step in the review UI; adds Germany to country fixtures and adds integration tests covering schema load, value prefill, and saving/navigation for Germany with
dynamic_steps.Reviewed by Cursor Bugbot for commit 994967e. Bugbot is set up for automated code reviews on this repo. Configure here.