Skip to content

fix(force-value-field) - avoid rendering statements without a description#964

Merged
gabrielseco merged 4 commits intomainfrom
fix-force-value-fields
Apr 28, 2026
Merged

fix(force-value-field) - avoid rendering statements without a description#964
gabrielseco merged 4 commits intomainfrom
fix-force-value-fields

Conversation

@gabrielseco
Copy link
Copy Markdown
Collaborator

@gabrielseco gabrielseco commented Apr 24, 2026

I was testing GER contract details v3 and I notice a force value field rendering...

I observe in our platform we have a hidden logic to avoid this.


Note

Low Risk
Low risk UI behavior change limited to ForcedValueField rendering conditions, covered by new tests; main impact is that some fields will no longer display when content is empty.

Overview
ForcedValueField now renders nothing when there’s no sanitized description and no statement.title, preventing empty/placeholder forced-value statements from showing up while still calling setValue on mount.

Tests were expanded to assert the hidden-render behavior (container.firstChild is null) and to ensure the form value is still set even when the component doesn’t render.

Reviewed by Cursor Bugbot for commit aa9872d. Bugbot is set up for automated code reviews on this repo. Configure here.

@gabrielseco gabrielseco self-assigned this Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 210.14 kB 210.17 kB -28 B (-0.0%) 🟢
Total (raw) 564.28 kB 564.27 kB +15 B (+0.0%) 🔴
CSS (gzip) 20.03 kB 20.03 kB 0 B (0%) 🟢
CSS (raw) 103.23 kB 103.23 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 210.14 kB / 250 kB (84.1%)
  • ✅ Total raw: 564.28 kB / 600 kB (94.0%)
  • ✅ CSS gzipped: 20.03 kB / 25 kB (80.1%)

Largest Files (Top 5)

  1. chunk-GBBJRWVT.js - 13.83 kB (0 B (0%))
  2. index.css - 10.01 kB (0 B (0%))
  3. styles.css - 10.01 kB (0 B (0%))
  4. index.js - 6.06 kB (-1 B (-0.0%))
  5. chunk-TNQKP2XT.js - 5.89 kB (0 B (0%))
View All Files (313 total)
File Size (gzip) Change
chunk-GBBJRWVT.js 13.83 kB 0 B (0%)
index.css 10.01 kB 0 B (0%)
styles.css 10.01 kB 0 B (0%)
index.js 6.06 kB -1 B (-0.0%)
chunk-TNQKP2XT.js 5.89 kB 0 B (0%)
chunk-GJO2C3U6.js 5.81 kB new
chunk-K3HVPXRN.js 4.51 kB new
chunk-Y7L6VZOT.js 4.29 kB new
chunk-DPVXTQAB.js 4.06 kB 0 B (0%)
chunk-JWLSIR3J.js 3.73 kB 0 B (0%)

✅ Bundle size check passed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 89.95% 89.94% 0%
Statements 89.62% 89.61% 0%
Functions 87.68% 87.68% 0%
Branches 80.08% 80.05% +0.03% 🟢

Detailed Breakdown

Lines Coverage
  • Covered: 3652 / 4060
  • Coverage: 89.95%
  • Change: 0% (3 lines)
Statements Coverage
  • Covered: 3713 / 4143
  • Coverage: 89.62%
  • Change: 0% (3 statements)
Functions Coverage
  • Covered: 996 / 1136
  • Coverage: 87.68%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 2263 / 2826
  • Coverage: 80.08%
  • Change: +0.03% (4 branches)

✅ Coverage check passed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-pozowd8p5-remotecom.vercel.app
Latest Commit:aa9872d
Inspect:View deployment

Deployed with vercel-action

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 236682b. Configure here.

Comment thread src/components/form/fields/ForcedValueField.tsx Outdated
@gabrielseco gabrielseco merged commit d6792e5 into main Apr 28, 2026
10 checks passed
@gabrielseco gabrielseco deleted the fix-force-value-fields branch April 28, 2026 11:31
@gabrielseco gabrielseco mentioned this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants