fix(tel-field) - fix tel field props#980
Merged
gabrielseco merged 3 commits intomainfrom Apr 29, 2026
Merged
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (313 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
cammellos
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Primarily a TypeScript type/prop refactor with small test harness adjustments; main risk is downstream compile/runtime issues if any consumers relied on the old
TelField-localTelFieldDataPropsshape.Overview
Fixes
TelFieldprop/type modeling by movingTelFieldDataPropsout ofTelField.tsxintosrc/types/fields.tsand basing it onFieldDataProps(rather thanJSFField), so custom tel components consistently receive the samefieldDatashape.Introduces a clearer
TelFieldPropstype (adds requirednameand optionalcomponent), updatesTelFieldand its tests to use the new types, and makes the test form resolver conditional onschemabeing provided.Reviewed by Cursor Bugbot for commit 0d2cadf. Bugbot is set up for automated code reviews on this repo. Configure here.