remotion: Make <Series> timeline-trimmable - #10000
Merged
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Type narrowing —
SeriesPropschanged fromSequencePropstoSequencePropsWithoutDuration, removingdurationInFramesfrom the<Series>prop type since children determine the total duration. - Schema narrowing —
durationInFramesexcluded from theseriesSchemavia destructure, so Studio no longer shows adurationInFramescontrol for<Series>. - New test — verifies the registered schema carries
fromandfreezebut notdurationInFrames. - Docs update — replaces the generic "accepts all Sequence props" with an explicit note that
durationInFramesis excluded and the duration is child-determined.
DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏
remotion: Align <Series> props with <TransitionSeries><Series> inherited controls
<Series> inherited controlsremotion: Make <Series> timeline-trimmable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
<Sequence>schema on<Series>, includingdurationInFrames<Series>outside its child cascading context so Studio exposes its trim handles<Series.Sequence>registered as an inside-Series cascading sequenceTests
bun test src/test/sequence-register-once.test.tsxbun run buildbun run stylecheckCloses #9997