Skip to content

remotion: Make <Series> timeline-trimmable - #10000

Merged
JonnyBurger merged 3 commits into
mainfrom
codex/align-series-sequence-props
Jul 31, 2026
Merged

remotion: Make <Series> timeline-trimmable#10000
JonnyBurger merged 3 commits into
mainfrom
codex/align-series-sequence-props

Conversation

@JonnyBurger

@JonnyBurger JonnyBurger commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

  • keep the complete inherited <Sequence> schema on <Series>, including durationInFrames
  • register the parent <Series> outside its child cascading context so Studio exposes its trim handles
  • keep each <Series.Sequence> registered as an inside-Series cascading sequence
  • add integration coverage for the inherited controls and parent timeline registration

Tests

  • bun test src/test/sequence-register-once.test.tsx
  • bun run build
  • bun run stylecheck

Closes #9997

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview Jul 31, 2026 10:05am
remotion Ready Ready Preview Jul 31, 2026 10:05am

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Type narrowingSeriesProps changed from SequenceProps to SequencePropsWithoutDuration, removing durationInFrames from the <Series> prop type since children determine the total duration.
  • Schema narrowingdurationInFrames excluded from the seriesSchema via destructure, so Studio no longer shows a durationInFrames control for <Series>.
  • New test — verifies the registered schema carries from and freeze but not durationInFrames.
  • Docs update — replaces the generic "accepts all Sequence props" with an explicit note that durationInFrames is excluded and the duration is child-determined.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

@JonnyBurger JonnyBurger changed the title remotion: Align <Series> props with <TransitionSeries> Internal: Test <Series> inherited controls Jul 31, 2026
@JonnyBurger JonnyBurger changed the title Internal: Test <Series> inherited controls remotion: Make <Series> timeline-trimmable Jul 31, 2026
@JonnyBurger
JonnyBurger merged commit 19df33d into main Jul 31, 2026
18 checks passed
@JonnyBurger
JonnyBurger deleted the codex/align-series-sequence-props branch July 31, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remotion: Re-evaluate <Series> inheriting all <Sequence> props

1 participant