Skip to content

Internal testbed: Remove package aliases - #10001

Merged
JonnyBurger merged 3 commits into
mainfrom
codex/derive-example-package-aliases
Jul 31, 2026
Merged

Internal testbed: Remove package aliases#10001
JonnyBurger merged 3 commits into
mainfrom
codex/derive-example-package-aliases

Conversation

@JonnyBurger

@JonnyBurger JonnyBurger commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

  • remove workspace package aliases now that ESM outputs are watched during development
  • let package exports maps handle root and subpath resolution normally
  • bundle the example testbed in the Linux PR build so broken subpath exports fail in CI

Validation

  • bun run bundle-testbed
  • bun run build
  • bun run stylecheck

Closes #9996

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview Jul 31, 2026 9:37am
remotion Ready Ready Preview Jul 31, 2026 9:37am

Request Review

@vercel
vercel Bot temporarily deployed to Preview – remotion July 31, 2026 09:25 Inactive
@JonnyBurger JonnyBurger changed the title Internal testbed: Derive package aliases from exports Internal testbed: Remove package aliases Jul 31, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Removed hardcoded webpack aliases — the 60-line aliases object in packages/example/src/webpack-override.mjs is gone; packages now resolve through their exports maps, which are kept in sync via the conventions in packages/transitions/package.json and the monorepo build pipeline
  • Added CI bundle testbun run bundle-testbed runs after the main bun run ci step in push.yml on ubuntu-latest, catching broken subpath exports before release (closes #9996)
  • Fixed skills test assertions(remotion-maps/REFERENCE.md) changed to (./remotion-maps/REFERENCE.md) in claude-code, codex, and kimi plugin tests; the old expectation was a looser substring match that would pass on the actual output regardless, so the new assertion is more specific
  • Added Codex-specific preview instructionsmakeRemotionCreateOpenPreview() in packages/codex-plugin/build.mts patches the generated remotion-create/SKILL.md to open the preview in the Codex in-app browser instead of a generic in-harness browser; the function throws if source text isn't found, keeping the plugin build in sync with skill changes
  • Added Codex preview test — verifies the codex plugin transforms the generated skill output correctly, asserting both the presence of the codex-specific text and the absence of the original wording
  • Grammar fix"If server is""If the server is" in remotion-create/SKILL.md

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

@JonnyBurger
JonnyBurger merged commit f62c57f into main Jul 31, 2026
17 checks passed
@JonnyBurger
JonnyBurger deleted the codex/derive-example-package-aliases branch July 31, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build: New subpath exports break the example bundle and are only caught at release time

1 participant