Internal testbed: Remove package aliases - #10001
Merged
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Removed hardcoded webpack aliases — the 60-line
aliasesobject inpackages/example/src/webpack-override.mjsis gone; packages now resolve through theirexportsmaps, which are kept in sync via the conventions inpackages/transitions/package.jsonand the monorepo build pipeline - Added CI bundle test —
bun run bundle-testbedruns after the mainbun run cistep inpush.ymlon ubuntu-latest, catching broken subpath exports before release (closes #9996) - Fixed skills test assertions —
(remotion-maps/REFERENCE.md)changed to(./remotion-maps/REFERENCE.md)in claude-code, codex, and kimi plugin tests; the old expectation was a looser substring match that would pass on the actual output regardless, so the new assertion is more specific - Added Codex-specific preview instructions —
makeRemotionCreateOpenPreview()inpackages/codex-plugin/build.mtspatches the generatedremotion-create/SKILL.mdto open the preview in the Codex in-app browser instead of a generic in-harness browser; the function throws if source text isn't found, keeping the plugin build in sync with skill changes - Added Codex preview test — verifies the codex plugin transforms the generated skill output correctly, asserting both the presence of the codex-specific text and the absence of the original wording
- Grammar fix —
"If server is"→"If the server is"inremotion-create/SKILL.md
DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
exportsmaps handle root and subpath resolution normallyValidation
bun run bundle-testbedbun run buildbun run stylecheckCloses #9996