Skip to content

@remotion/studio: Allow precise scale input - #10065

Merged
JonnyBurger merged 1 commit into
mainfrom
codex/allow-precise-scale-input
Aug 2, 2026
Merged

@remotion/studio: Allow precise scale input#10065
JonnyBurger merged 1 commit into
mainfrom
codex/allow-precise-scale-input

Conversation

@JonnyBurger

Copy link
Copy Markdown
Member

Summary

  • allow scale fields to accept typed values that do not align with the interaction step
  • keep scale dragging and arrow-key increments at the configured step
  • add a Studio browser regression test that persists scale: 0.525

Test plan

  • bun run build
  • bun run stylecheck
  • bunx playwright test e2e/effect-keyframes.test.mts --project=chromium

Closes #9765

@vercel

vercel Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview Aug 2, 2026 3:35pm
remotion Ready Ready Preview Aug 2, 2026 3:35pm

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • InputDragger: Add allowStepMismatch prop — Typed values bypass step-alignment validation (step='any') while dragging and arrow key increments remain aligned to the configured step.
  • TimelineScaleField: Enable precise scale input — Pass allowStepMismatch on the X and Y scale draggers so users can type values like 0.525.
  • E2E test — Opens an EffectKeyframeE2e composition with a named scale control, types 0.525, presses ArrowUp to verify it produces 0.535, types 0.525 again, commits with Enter, and asserts the value was written to source.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

@JonnyBurger
JonnyBurger merged commit 596523d into main Aug 2, 2026
20 checks passed
@JonnyBurger
JonnyBurger deleted the codex/allow-precise-scale-input branch August 2, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scale InputDragger does not allow scale=0.525

1 participant