Skip to content

@remotion/studio: Prevent visibility toggle double clicks#9575

Merged
JonnyBurger merged 1 commit into
mainfrom
codex/studio-eye-double-click
Jul 24, 2026
Merged

@remotion/studio: Prevent visibility toggle double clicks#9575
JonnyBurger merged 1 commit into
mainfrom
codex/studio-eye-double-click

Conversation

@JonnyBurger

Copy link
Copy Markdown
Member

Summary

  • prevent double-clicks on timeline visibility controls from reaching the row
  • preserve click-and-drag visibility toggling across timeline tracks

Checks

  • bun run build
  • bun run stylecheck
  • bunx turbo run lint test --filter='@remotion/studio'

Closes #9574

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Jul 24, 2026 11:58am
remotion Ready Ready Preview, Comment Jul 24, 2026 11:58am

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — adds double-click event protection to the timeline visibility toggle, preventing rapid double-clicks on the eye/speaker/effect icon from reaching the parent timeline row.

  • Add onDoubleClick handler to TimelineLayerEye — calls e.stopPropagation() to block the double-click event from reaching the parent row, matching the existing defensive pattern used by onDragStart and onPointerDown.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

@JonnyBurger
JonnyBurger merged commit b414e69 into main Jul 24, 2026
19 checks passed
@JonnyBurger
JonnyBurger deleted the codex/studio-eye-double-click branch July 24, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking the eye icon twice fast counts as double click

1 participant