@remotion/studio-server: Detect current VS Code macOS process - #9999
Conversation
There was a problem hiding this comment.
ℹ️ No critical issues — one minor observation inline.
Reviewed changes — one commit adding Code process detection for current VS Code on macOS, refactoring the detection loop into a testable function, and adding a unit test.
- New VS Code macOS executable mapping — adds
/Applications/Visual Studio Code.app/Contents/MacOS/CodetoCOMMON_EDITORS_OSX, preserving the olderElectronentry for backwards compatibility - Extracted
findMacOsEditorsFromProcessOutput— moves the macOS process-detection loop out ofguessEditorso it can be tested directly; replacesindexOfwithincludes(equivalent) - Regression test — verifies the new
Codeprocess name is detected from representativepsoutput
Note: 1 inline comment(s) dropped because they did not anchor to lines inside the PR diff:
packages/claude-code-plugin/test/plugin.test.ts:17(RIGHT) — line 17 (RIGHT) is not inside a diff hunk
DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — two commits: adding Code process detection for current VS Code on macOS, refactoring the detection loop, and fixing skill reference assertions in plugin tests.
- New VS Code macOS executable mapping — adds
/Applications/Visual Studio Code.app/Contents/MacOS/CodetoCOMMON_EDITORS_OSX, preserving the olderElectronentry for backwards compatibility - Extracted
findMacOsEditorsFromProcessOutput— moves the macOS process-detection loop out ofguessEditorso it can be tested directly - Regression test — verifies the new
Codeprocess name is detected from representativepsoutput - Fixed plugin test skill assertions — updates embedded maps link expectations to use
./prefixed paths
DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

Summary
psoutputTesting
bun test packages/studio-server/src/test/open-in-editor.test.tsbun run buildbun run stylecheck