Skip to content

@remotion/studio-server: Detect current VS Code macOS process - #9999

Merged
JonnyBurger merged 2 commits into
mainfrom
codex/detect-vscode-macos-process
Jul 31, 2026
Merged

@remotion/studio-server: Detect current VS Code macOS process#9999
JonnyBurger merged 2 commits into
mainfrom
codex/detect-vscode-macos-process

Conversation

@JonnyBurger

Copy link
Copy Markdown
Member

Summary

  • detect the current VS Code macOS process executable
  • preserve support for the previous Electron executable name
  • add regression coverage for representative ps output

Testing

  • bun test packages/studio-server/src/test/open-in-editor.test.ts
  • bun run build
  • bun run stylecheck
  • manually verified that Remotion Studio enables “Open in VS Code”

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview Jul 31, 2026 9:25am
remotion Ready Ready Preview Jul 31, 2026 9:25am

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one minor observation inline.

Reviewed changes — one commit adding Code process detection for current VS Code on macOS, refactoring the detection loop into a testable function, and adding a unit test.

  • New VS Code macOS executable mapping — adds /Applications/Visual Studio Code.app/Contents/MacOS/Code to COMMON_EDITORS_OSX, preserving the older Electron entry for backwards compatibility
  • Extracted findMacOsEditorsFromProcessOutput — moves the macOS process-detection loop out of guessEditor so it can be tested directly; replaces indexOf with includes (equivalent)
  • Regression test — verifies the new Code process name is detected from representative ps output

Note: 1 inline comment(s) dropped because they did not anchor to lines inside the PR diff:

  • packages/claude-code-plugin/test/plugin.test.ts:17 (RIGHT) — line 17 (RIGHT) is not inside a diff hunk

Pullfrog  | Fix it ➔View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — two commits: adding Code process detection for current VS Code on macOS, refactoring the detection loop, and fixing skill reference assertions in plugin tests.

  • New VS Code macOS executable mapping — adds /Applications/Visual Studio Code.app/Contents/MacOS/Code to COMMON_EDITORS_OSX, preserving the older Electron entry for backwards compatibility
  • Extracted findMacOsEditorsFromProcessOutput — moves the macOS process-detection loop out of guessEditor so it can be tested directly
  • Regression test — verifies the new Code process name is detected from representative ps output
  • Fixed plugin test skill assertions — updates embedded maps link expectations to use ./ prefixed paths

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

@JonnyBurger
JonnyBurger merged commit db7100e into main Jul 31, 2026
32 of 33 checks passed
@JonnyBurger
JonnyBurger deleted the codex/detect-vscode-macos-process branch July 31, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant