fix: packageRules[0].minimumReleaseAge should be a string#910
Closed
reubenjds wants to merge 1 commit intorenovatebot:mainfrom
Closed
fix: packageRules[0].minimumReleaseAge should be a string#910reubenjds wants to merge 1 commit intorenovatebot:mainfrom
reubenjds wants to merge 1 commit intorenovatebot:mainfrom
Conversation
Contributor
|
This looks to be a very poor choice of example altogether! This is not the only fix required |
jamietanna
added a commit
that referenced
this pull request
Nov 7, 2025
As noted in #910, we have invalid configuration shared as an example, which isn't ideal. We should validate any JSON and `config.js` files in the example directory. This is a separate check to allow us to run it only for changes to the examples, or the Workflow definition.
Contributor
|
I've re-raised this in #963, as I can't push back to your repo to amend a change (as you're pushing from |
jamietanna
added a commit
that referenced
this pull request
Nov 7, 2025
As noted in #910, we have invalid configuration shared as an example, which isn't ideal. We should validate any JSON and `config.js` files in the example directory. This is a separate check to allow us to run it only for changes to the examples, or the Workflow definition.
viceice
approved these changes
Nov 7, 2025
Contributor
|
Replaced by #963 - thanks again for the fix! |
jamietanna
added a commit
that referenced
this pull request
Dec 15, 2025
As noted in #910, we have invalid configuration shared as an example, which isn't ideal. We should validate any JSON and `config.js` files in the example directory.
jamietanna
added a commit
that referenced
this pull request
Dec 15, 2025
As noted in #910, we have invalid configuration shared as an example, which isn't ideal. We should validate any JSON and `config.js` files in the example directory. We need to make sure that we override the ESM settings in this repo, as otherwise we receive: module is not defined in ES module scope This also follows the usage of a container from Renovate[0] for using the container to run the validator. Co-authored-by: gpt-4.1 <jamie.tanna+github-copilot@mend.io> [0]: https://github.com/renovatebot/.github/blob/2ab0f77818/.github/workflows/test.yml#L44
jamietanna
added a commit
that referenced
this pull request
Dec 15, 2025
As noted in #910, we have invalid configuration shared as an example, which isn't ideal. We should validate any JSON and `config.js` files in the example directory. We need to make sure that we override the ESM settings in this repo, as otherwise we receive: module is not defined in ES module scope This also follows the usage of a container from Renovate[0] for using the container to run the validator. Co-authored-by: gpt-4.1 <jamie.tanna+github-copilot@mend.io> [0]: https://github.com/renovatebot/.github/blob/2ab0f77818/.github/workflows/test.yml#L44
jamietanna
added a commit
that referenced
this pull request
Dec 15, 2025
As noted in #910, we have invalid configuration shared as an example, which isn't ideal. We should validate any JSON and `config.js` files in the example directory. We need to make sure that we override the ESM settings in this repo, as otherwise we receive: module is not defined in ES module scope This also follows the usage of a container from Renovate[0] for using the container to run the validator. Co-authored-by: gpt-4.1 <jamie.tanna+github-copilot@mend.io> [0]: https://github.com/renovatebot/.github/blob/2ab0f77818/.github/workflows/test.yml#L44
jamietanna
added a commit
that referenced
this pull request
Dec 15, 2025
As noted in #910, we have invalid configuration shared as an example, which isn't ideal. We should validate any JSON and `config.js` files in the example directory. This also follows the usage of a container from Renovate[0] for using the container to run the validator. [0]: https://github.com/renovatebot/.github/blob/2ab0f77818/.github/workflows/test.yml#L44
jamietanna
added a commit
that referenced
this pull request
Dec 15, 2025
As noted in #910, we have invalid configuration shared as an example, which isn't ideal. We should validate any JSON and `config.js` files in the example directory. This also follows the usage of a container from Renovate[0] for using the container to run the validator. [0]: https://github.com/renovatebot/.github/blob/2ab0f77818/.github/workflows/test.yml#L44
jamietanna
added a commit
that referenced
this pull request
Dec 15, 2025
As noted in #910, we have invalid configuration shared as an example, which isn't ideal. We should validate any JSON and `config.js` files in the example directory. We need to make sure that we override the ESM settings in this repo, as otherwise we receive: module is not defined in ES module scope When trying to validate the `renovate-config.js`. This also follows the usage of a container from Renovate[0] for using the container to run the validator. [0]: https://github.com/renovatebot/.github/blob/2ab0f77818/.github/workflows/test.yml#L44
viceice
pushed a commit
that referenced
this pull request
Dec 15, 2025
As noted in #910, we have invalid configuration shared as an example, which isn't ideal. We should validate any JSON and `config.js` files in the example directory. We need to make sure that we override the ESM settings in this repo, as otherwise we receive: module is not defined in ES module scope When trying to validate the `renovate-config.js`. This also follows the usage of a container from Renovate[0] for using the container to run the validator. [0]: https://github.com/renovatebot/.github/blob/2ab0f77818/.github/workflows/test.yml#L44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to the error I got when using the example renovate-config.json