[gomod] major updates break for packages with few / in package name

[Shegox]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitHub Enterprise Server/39.257.1

Please tell us more about your question or problem

When updating to a new major version in Go modules, Renovate modifies the package suffix from, for example, /v4 to /v6. However, if the package name does not adhere to the github.com/org/repo structure and instead consists of a simpler format like /package-name, such as sigs.k8s.io/structured-merge-diff, Renovate incorrectly appends the new version suffix instead of replacing the existing one, resulting in sigs.k8s.io/structured-merge-diff/v4/v6.

Upon investigation, I discovered the issue in the following code segment of Renovate:

renovate/lib/modules/manager/gomod/update.ts

Lines 6 to 12 in 7ed07b1

	function getNameWithNoVersion(name: string): string {
	let nameNoVersion = name.split('/').slice(0, 3).join('/');
	if (nameNoVersion.startsWith('gopkg.in')) {
	nameNoVersion = nameNoVersion.replace(regEx(/\.v\d+$/), '');
	}
	return nameNoVersion;
	}

This code attempts to extract the package name without the version by utilizing a splitting logic, which works for github.com packages that follow the github.com/org/repo syntax, but fails for packages hosted elsewhere.

To resolve this issue, I suggest modifying the code to remove the /v\d+ part of the URL, operating under the assumption that no package is actually named /v1:

function getNameWithNoVersion(name: string): string {
  // Remove version suffixes like /v1 or /v2
  let nameNoVersion = name.replace(/\/v\d+$/, '');
  // Handle gopkg.in special case where the major version is added with a dot rather than a slash
  if (nameNoVersion.startsWith('gopkg.in')) {
    nameNoVersion = nameNoVersion.replace(/\.v\d+$/, '');
  }
  return nameNoVersion;
}

I have a corresponding Pull Request ready and will open it in a second. (Edit: #35508)

You can see the reproduction pull request here: https://github.com/Shegox/major-update-problem/pull/2/files

Logs (if relevant)

Logs

Logs from https://developer.mend.io/github/Shegox/major-update-problem/-/job/01966391-b2ff-738e-980b-ab06ac0f0055

DEBUG: manager.getUpdatedPackageFiles() reuseExistingBranch=false (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
DEBUG: gomod.updateDependency: v6.0.0 (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
DEBUG: gomod: major update for sigs.k8s.io/structured-merge-diff/v4 (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
DEBUG: Updating sigs.k8s.io/structured-merge-diff/v4 in go.mod (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
DEBUG: updateArtifacts for updatedPackageFiles (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
DEBUG: gomod.updateArtifacts(go.mod) (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
DEBUG: go mod tidy command skipped (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
DEBUG: Setting CONTAINERBASE_CACHE_DIR to /runner/cache/containerbase (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
DEBUG: Using containerbase dynamic installs (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
DEBUG: Resolved stable matching version (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
{
  "toolName": "golang"
  "constraint": "^1.18"
  "resolvedVersion": "1.24.2"
}

DEBUG: Executing command (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
{
  "command": "install-tool golang 1.24.2"
}

DEBUG: exec completed (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
{
  "durationMs": 519
  "stdout": "[16:54:17.359] INFO (1119): Installing tool golang@1.24.2...\ntool golang v1.24.2 is already installed\ntool is already linked: golang v1.24.2\n[16:54:17.476] INFO (1119): Install tool golang succeeded in 141ms.\n"
  "stderr": ""
}

DEBUG: Executing command (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
{
  "command": "go get -d -t ./..."
}

DEBUG: rawExec err (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
{
  "err": {
    "cmd": "/bin/sh -c go get -d -t ./...",
    "stderr": "go: -d flag is deprecated. -d=true is a no-op\ngo: sigs.k8s.io/structured-merge-diff/v4/v6@v6.0.0: reading sigs.k8s.io/structured-merge-diff/v4/go.mod at revision v4/v6.0.0: unknown revision v4/v6.0.0\n",
    "stdout": "",
    "options": {
      "cwd": "/tmp/renovate/repos/github/Shegox/major-update-problem",
      "encoding": "utf-8",
      "env": {
        "GOPATH": "/runner/cache/others/go",
        "GOSUMDB": "off",
        "GOFLAGS": "-modcacherw",
        "GIT_CONFIG_KEY_0": "url.https://**redacted**@github.com/.insteadOf",
        "GIT_CONFIG_VALUE_0": "ssh://**redacted**@github.com/",
        "GIT_CONFIG_KEY_1": "url.https://**redacted**@github.com/.insteadOf",
        "GIT_CONFIG_VALUE_1": "git@github.com:",
        "GIT_CONFIG_KEY_2": "url.https://**redacted**@github.com/.insteadOf",
        "GIT_CONFIG_VALUE_2": "https://github.com/",
        "GIT_CONFIG_COUNT": "3",
        "HOME": "/home/ubuntu",
        "PATH": "/home/ubuntu/.local/bin:/home/ubuntu/bin:/home/ubuntu/.local/bin:/home/ubuntu/bin:/home/ubuntu/.local/bin:/home/ubuntu/bin:/home/ubuntu/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
        "LC_ALL": "C.UTF-8",
        "LANG": "C.UTF-8",
        "CONTAINERBASE_CACHE_DIR": "/runner/cache/containerbase"
      },
      "maxBuffer": 10485760,
      "timeout": 900000
    },
    "exitCode": 1,
    "name": "ExecError",
    "message": "Command failed: go get -d -t ./...\ngo: -d flag is deprecated. -d=true is a no-op\ngo: sigs.k8s.io/structured-merge-diff/v4/v6@v6.0.0: reading sigs.k8s.io/structured-merge-diff/v4/go.mod at revision v4/v6.0.0: unknown revision v4/v6.0.0\n",
    "stack": "ExecError: Command failed: go get -d -t ./...\ngo: -d flag is deprecated. -d=true is a no-op\ngo: sigs.k8s.io/structured-merge-diff/v4/v6@v6.0.0: reading sigs.k8s.io/structured-merge-diff/v4/go.mod at revision v4/v6.0.0: unknown revision v4/v6.0.0\n\n    at ChildProcess.<anonymous> (/usr/local/renovate/lib/util/exec/common.ts:119:11)\n    at ChildProcess.emit (node:events:530:35)\n    at ChildProcess.emit (node:domain:489:12)\n    at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)"
  }
  "durationMs": 438
}

DEBUG: Failed to update go.sum (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")
{
  "err": {
    "cmd": "/bin/sh -c go get -d -t ./...",
    "stderr": "go: -d flag is deprecated. -d=true is a no-op\ngo: sigs.k8s.io/structured-merge-diff/v4/v6@v6.0.0: reading sigs.k8s.io/structured-merge-diff/v4/go.mod at revision v4/v6.0.0: unknown revision v4/v6.0.0\n",
    "stdout": "",
    "options": {
      "cwd": "/tmp/renovate/repos/github/Shegox/major-update-problem",
      "encoding": "utf-8",
      "env": {
        "GOPATH": "/runner/cache/others/go",
        "GOSUMDB": "off",
        "GOFLAGS": "-modcacherw",
        "GIT_CONFIG_KEY_0": "url.https://**redacted**@github.com/.insteadOf",
        "GIT_CONFIG_VALUE_0": "ssh://**redacted**@github.com/",
        "GIT_CONFIG_KEY_1": "url.https://**redacted**@github.com/.insteadOf",
        "GIT_CONFIG_VALUE_1": "git@github.com:",
        "GIT_CONFIG_KEY_2": "url.https://**redacted**@github.com/.insteadOf",
        "GIT_CONFIG_VALUE_2": "https://github.com/",
        "GIT_CONFIG_COUNT": "3",
        "HOME": "/home/ubuntu",
        "PATH": "/home/ubuntu/.local/bin:/home/ubuntu/bin:/home/ubuntu/.local/bin:/home/ubuntu/bin:/home/ubuntu/.local/bin:/home/ubuntu/bin:/home/ubuntu/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
        "LC_ALL": "C.UTF-8",
        "LANG": "C.UTF-8",
        "CONTAINERBASE_CACHE_DIR": "/runner/cache/containerbase"
      },
      "maxBuffer": 10485760,
      "timeout": 900000
    },
    "exitCode": 1,
    "name": "ExecError",
    "message": "Command failed: go get -d -t ./...\ngo: -d flag is deprecated. -d=true is a no-op\ngo: sigs.k8s.io/structured-merge-diff/v4/v6@v6.0.0: reading sigs.k8s.io/structured-merge-diff/v4/go.mod at revision v4/v6.0.0: unknown revision v4/v6.0.0\n",
    "stack": "ExecError: Command failed: go get -d -t ./...\ngo: -d flag is deprecated. -d=true is a no-op\ngo: sigs.k8s.io/structured-merge-diff/v4/v6@v6.0.0: reading sigs.k8s.io/structured-merge-diff/v4/go.mod at revision v4/v6.0.0: unknown revision v4/v6.0.0\n\n    at ChildProcess.<anonymous> (/usr/local/renovate/lib/util/exec/common.ts:119:11)\n    at ChildProcess.emit (node:events:530:35)\n    at ChildProcess.emit (node:domain:489:12)\n    at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)"
  }
}

DEBUG: Updated 1 package files (branch="renovate/sigs.k8s.io-structured-merge-diff-v4-6.x")

[Shegox]

Fixed via #35508 released in 39.257.4