osvVulnerabilityAlerts ignores major.enabled: false and packageRules cannot block major updates for OSV vulnerability fixes
#42760
dn281090pdi
started this conversation in
Suggest an Idea
Replies: 2 comments 5 replies
|
@RahulGautamSingh this looks like "as expected", right? We generally don't allow a Vulnerability Alert to be ignored? (as we use |
1 reply
|
Works as expected. Move these package rules into the |
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Tell us more.
When using
osvVulnerabilityAlerts: trueon a self-hosted Renovate (v43.2.4) with GitLab platform, major updates created by OSV vulnerability fixes cannot be disabled through any configuration option.OSV vulnerability pipeline creates PRs/MRs for major updates regardless of:
"major": { "enabled": false }at top levelpackageRuleswith"matchUpdateTypes": ["major"], "enabled": false(last rule)vulnerabilityAlerts.packageRuleswith"matchUpdateTypes": ["major"], "enabled": falseAll three approaches were tested and major MRs are still created.
Expected behavior
At least one of the above configuration options should prevent Renovate from creating branches/MRs for major version updates when the vulnerability fix requires a major bump.
Reproduction
Renovate version: 43.2.4
Platform: GitLab (self-hosted, 18.8.3-ee)
Self-hosted
Config (minimal reproduction):
{ "osvVulnerabilityAlerts": true, "major": { "enabled": false }, "packageRules": [ { "matchPackageNames": ["*"], "enabled": false }, { "description": "Allow patch/minor vulnerability alerts", "isVulnerabilityAlert": true, "matchUpdateTypes": ["patch", "digest", "minor"], "enabled": true }, { "description": "Block major updates — last rule", "matchUpdateTypes": ["major"], "matchPackageNames": ["*"], "enabled": false } ] }What happens:
OSV detects vulnerabilities where the fix requires a major version bump (e.g.,
react-dev-utils5.0.3 → 11.0.4,webpack-dev-server3.1.14 → 5.2.1). Despite all major-blocking rules, Renovate creates branches and MRs for these major updates.All reactions