How config merging behave with the preset :automergeMinor

[scrocquesel-ml150]

How are you running Renovate?

Self-hosted Renovate CLI

Which platform you running Renovate on?

Other (please specify)

Which version of Renovate are you using?

43.220.0

Please tell us more about your question or problem

On Azure DevOps, I have this package rule

    {
      "description": "automerge minor core-back packages",
      "extends": [
        ":automergeMinor",
        ":label(deploy_pr)"
      ],
      "matchSourceUrls": [
        "https://private_repo",
      ],
      "autoApprove": true
    }

I was expecting that label, and autoApprove be applied only for lockFileMaintenance, minor, patch, pin. But it is not. I have Major update with both the label and approval but not automerging. All the rules with autoApprove and label are extending automergeMinor, so it is unlikely that another rules applied those.

Is there a simple way, to specify more actions on automergeMinor matchers ? What I would like is

    {
      "description": "automerge minor core-back packages",
      "extends": [
        ":automergeMinor",
        ":label(deploy_pr)"
      ],
      "matchSourceUrls": [
        "https://private_repo",
      ],
      "lockFileMaintenance": {
           "extends": [
                ":label(deploy_pr)"
          ],
          "autoApprove": true
        },
        "minor": {
           "extends": [
                ":label(deploy_pr)"
          ],
          "autoApprove": true
        },
        "patch": {
           "extends": [
                ":label(deploy_pr)"
          ],
          "autoApprove": true
        },
        "pin": {
           "extends": [
                ":label(deploy_pr)"
          ],
          "autoApprove": true
        }

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[jamietanna]

@RahulGautamSingh can you take a look please? I remember you saying there was some work you were doing on documenting config merging

[RahulGautamSingh]

@scrocquesel-ml150

Your assumption that, the presets within packageRules are spread into the parent object is correct.

Your packageRule:

{
  "extends": [":automergeMinor", ":label(deploy_pr)"],
  "matchSourceUrls": ["https://private_repo"],
  "autoApprove": true
}

After resolution it spreads into:

{
  "matchSourceUrls": ["https://private_repo"],
  "minor": { "automerge": true },
  "patch": { "automerge": true },
  "pin":   { "automerge": true },
  "lockFileMaintenance": { "automerge": true },
  "addLabels": ["deploy_pr"],
  "autoApprove": true
}

What you got wrong was the config of automergeMinor..

• automerge is correctly scoped to minor/patch/pin/lockfile, because the preset nested it under those update-type keys.
• But autoApprove: true and the label sit at the packageRule top level, not nested under an update type. So they apply to everything matching matchSourceUrls including major.

You assumed extending :automergeMinor would scope their sibling keys too, but only the keys the preset itself nests under minor/patch/etc. get that scoping. Their own autoApprove/label don't inherit it.

minor/pathc/pin are config object of their own and should always be used on top level, so extending automergeMinor won't get the desired outcome.

You can try this:

{
  "packageRules": [
    {
      "matchSourceUrls": ["https://private_repo"],
      "matchUpdateTypes": ["minor", "patch", "pin", "lockFileMaintenance"],
      "automerge": true,
      "autoApprove": true,
      "addLabels": ["deploy_pr"]
    }
  ]
}

[scrocquesel]

So why automergeMinor don't use matchUpdateType ? It is not very common to have preset that nest (isolate) their actions.
Its like this preset should only be used as a top level preset and not in a package rule.
Maybe the documentation could say that and equivalent built in presets could be provided for package rule scope rules ?

[RahulGautamSingh]

I agree. Could you create a PR for that?

[scrocquesel-ml150]

I agree. Could you create a PR for that?

Do you mean for the doc only ? For the preset, do you have any naming rule for the preset ? I guess there is a few others that may apply for package scope

[RahulGautamSingh]

No, I meant you can update the preset config to move from using minor/major to matchUpdateTypes. As long as behavior is not changing we can use the same name