Grouping error with zizmor-pre-commit #44958
How are you running Renovate?A Mend.io-hosted app Which platform you running Renovate on?GitHub.com Which version of Renovate are you using?43.280.0 Please tell us more about your question or problemI'm using renovate on https://github.com/ulgens/django-blasphemy/ with https://github.com/ulgens/renovate-presets (latest commit as of now is ulgens/renovate-presets@cff6cfa) I have this PR: ulgens/django-blasphemy#1125 for the "Python packages" group defined as https://github.com/ulgens/renovate-presets/blob/cff6cfa19c4075140a025f839d66a95089f2c4ba/python.json5#L15 It includes In the logs, I can see that the dependency is recognized as It looks like the recognition is fine, and renovate is not mistaking the datasource. Still, the package is categorized under an unrelated group. This issue's been going for a while and it's consistent for multiple numbers of repos I'm managing. I believe this is a bug. Logs (if relevant)Logs |
Replies: 1 comment 3 replies
|
This comes from category matching, not datasource detection. Renovate Your So this dependency matches both rules:
Exclude pre-commit manager from both broad Python-package rules: {
"groupName": "Python Packages",
"matchCategories": ["python"],
"matchManagers": ["!pre-commit"],
},
{
"groupName": "Python Packages",
"matchDatasources": ["pypi"],
"matchManagers": ["!pre-commit"],
},Keep later Reordering presets would also fix this one dependency, but manager exclusions express intent more precisely and preserve selected |
Created pr: #45005