minimumReleaseAge resets the wait when a newer release is published #45037
Replies: 2 comments 1 reply
|
@Tanguille this might be better as a "Request Help" - we'd likely need an example of this happening before we can triage further |
1 reply
|
Hi there, Please help this Discussion progress by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible. Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues. Please follow these steps:
If you need help with running Renovate on your minimal reproduction repository, please refer to our Running Renovate guide. The Renovate team |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Raising this discussion after a discord conversation with @jamietanna.
Problem:
When an update has passed
minimumReleaseAgeand Renovate opens a PR for it, a subsequent release that hasn't yet passed MRA appears to update that same PR resetting the clock on the release that had already cleared the age gate, rather than leaving that PR alone and opening a separate PR for the newer release once it clears MRA.Expected per @jamietanna:
"An update that has passed MRA will have a PR opened, but if a subsequent release is published, but hasn't passed MRA, it shouldn't update the existing PR until it's passed MRA" so this shouldn't be happening today.
What we had to disable to work around it:
We set
rebaseWhen: "never"on our production package rules. Without it, a newer release that clears its own MRA window rewrites the still-open PR in place, so production would skip the exact version we'd actually validated on staging. The same resetting behavior described above, just via rebase instead of MRA. Turning that off serializes production onto "one open PR at a time, only advanced by merging it," which is a blunter tool than we'd like. It also blocks legitimate rebases we might otherwise want.Suggestion:
Could there be a configuration option that causes subsequent releases to be opened in a new PR so the ones not merged yet are left alone and the MRA is unaffected? That seems like the ideal solution for this after analyzing this.
All reactions