fix: separate-weights build with r8.im image names fails schema validation

[michaeldwan]

Building with --separate-weights and an r8.im/ image name fails at post-build schema validation with No such image: cog-tmp:<hash>.

The cog-tmp temporary tag was introduced in #2658 to avoid tagging intermediate builds with registry names. The non-separate-weights path uses it correctly, but the separate-weights path was missed -- it tagged the runner image with the final imageName instead of tmpImageId. Post-build steps (schema validation, pip freeze, label addition) then can't find the temp image.

One-line fix: buildRunnerImage in the separate-weights path now gets tmpImageId instead of imageName, consistent with the other build paths. The existing BuildAddLabelsAndSchemaToImage call already handles re-tagging from tmpImageId to imageName as the final step.

Integration test reproduces the exact failure. Uses --use-cog-base-image=false so it doesn't hit the real r8.im registry.

Fixes #2953

[ask-bonk]

@michaeldwan Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

[ask-bonk]

I'm Bonk, and I've done a quick review of your PR.

This fixes a bug where --separate-weights builds with r8.im/ image names fail at post-build schema validation because the runner image was tagged with the full imageName instead of the temporary tmpImageId (cog-tmp:<hash>).

The fix is correct and consistent with the non-separate-weights path. The integration test properly reproduces the issue and verifies the fix.

LGTM

github run