[websocket] use background tasks instead of cleanup function #100
Merged
[websocket] use background tasks instead of cleanup function #100
Conversation
)" This reverts commit 2d5fb02.
Why === * The cleanup function added a burden on the caller to make sure the tasks were awaited. * Instead, follow the advice of https://docs.python.org/3/library/asyncio-task.html#asyncio.create_task and store them in the background properly What changed === * Revert cleanup commit * Add background websocket task storage Test plan === * Ran a pytest, and didn't see "Pending task destroyed" exceptions
ryantm
force-pushed
the
rtm-10-11-background-task-instead
branch
from
fa07599 to
1c344d9
Compare
jackyzha0
approved these changes
Oct 11, 2024
Member
jackyzha0
left a comment
jackyzha0
left a comment
There was a problem hiding this comment.
lgtm but would wait for someone with more python experience to approve :)
lhchavez
approved these changes
Oct 11, 2024
| from websockets import WebSocketCommonProtocol | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
| _background_tasks: set[asyncio.Task] = set() |
Collaborator
There was a problem hiding this comment.
fine. don't love the idea of having another global, but the alternative is to re-add all the complexity. lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
tasks were awaited.
https://docs.python.org/3/library/asyncio-task.html#asyncio.create_task
and store them in the background properly
What changed
Test plan