Skip to content

Conversation

@krasoffski
Copy link
Contributor

@krasoffski krasoffski commented Dec 4, 2017

As was noted in the pytest-dev@python.org mailing list,

MarkMapping is only complete enough to fulfill its internal use case.

That is why was decided to duplicate logic of from_keyword class method in our plug-in.
Other solution with checking existence of attributes and parsing pytest version looks even worser personally for me.

@lebovski
Copy link

lebovski commented Dec 5, 2017

I test that fix locally on both pytest, all works.

@lebovski
Copy link

lebovski commented Dec 5, 2017

Your fix support of new pytest, version bump?

Copy link

@ailjushkin ailjushkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, LGTM

@ailjushkin ailjushkin merged commit 775e6c9 into reportportal:master Dec 5, 2017
@krasoffski krasoffski deleted the issue_37 branch December 5, 2017 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants