fix(health): count TS object-literal shorthand properties as reads

[RaghavChamadiya]

Problem

The ts_js def/use dialect classifies only plain identifier nodes as variable reads. It knows shorthand_property_identifier_pattern (the destructuring binder, a def) but never counts shorthand_property_identifier, the object-literal read in { days, limit }. Those reads were invisible to the dataflow layer.

Impact on shipped consumers:

• Extract Method IN/OUT inference on TS/JS can omit a variable a candidate span consumes via shorthand, producing a wrong parameter list.
• This violates the documented precision-first contract in defuse.py (unresolvable identifiers are reads).

Concrete repros: packages/api-client/src/graph.ts::getHotFilesGraph reported days and limit as unused parameters even though both are consumed at line 97 via shorthand; same for providers.ts::setActiveProvider (provider) and packages/vscode/src/features/trees/shared.ts::section (key, label).

Fix

Extend the dialect's identifier_kinds with shorthand_property_identifier. Grammar introspection across the typescript, tsx, and javascript packs confirms the non-pattern kind only ever appears in read position (object literals); destructuring binders, including assignment-LHS destructuring, always parse as the _pattern variant. So this adds reads and can never introduce a false def.

Tests

New fixtures in tests/unit/health/test_dataflow_langs.py:

• shorthand reads in a return object (return { days, limit, payload })
• LHS destructuring def mixed with RHS shorthand read on the same statement (const { a } = { ...source, b })
• spread plus shorthand on the plain JS grammar

Full health suite (921 tests) passes with no extract-method golden shifts. Full unit suite passes except the pre-existing test_bundled_changelog_in_sync failure, which is unrelated (bundled changelog drifted on main).

Rerunning the tree-wide dataflow sweep confirms the three shorthand false-positive repros above are gone.

Perf-neutral: the change adds one string to a frozenset consulted in an existing membership check.

[repowise-bot]

✅ Health: 7.7 (unchanged)

📋 At a glance
2 hotspots touched.

Files & modules (2)

• packages (1 file)
  • .../dialects/ts_js.py
• tests (1 file)
  • .../health/test_dataflow_langs.py

🔎 More signals (1)

🔥 Hotspots touched (2)

• .../dialects/ts_js.py — 1 commits/90d, 1 dependents · primary owner: Raghav Chamadiya (100%)
• .../health/test_dataflow_langs.py — 2 commits/90d, 0 dependents · primary owner: Raghav Chamadiya (100%)

---

📊 Full report · ⭐ Star Repowise · 📥 Install bot · Last updated 2026-07-10 15:25 UTC
_{Silence on a single PR with [skip repowise] in the title · Per-repo toggle on repowise.dev/settings?tab=bot}