Grant the provenance job contents: write so the release workflow can start - #36
Merged
Merged
Conversation
The SLSA generator declares an upload-assets job requiring contents: write. GitHub validates a called workflow's declared permissions when the run is created, before any if: guard is evaluated, so granting contents: read made the entire workflow fail with startup_failure and no job ever ran. upload-assets is false, so that job still never executes and the release job remains the only thing that attaches assets. The previous comment reasoned correctly about runtime and drew the wrong conclusion about startup. Signed-off-by: reesebuilt <126643625+reesepj@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow could not start at all. Two
workflow_dispatchdry runs returnedstartup_failurewith zero jobs created.Cause: the SLSA generator declares an
upload-assetsjob requiringcontents: write. GitHub validates a called workflow's DECLARED permissions when the run is created, before anyif:guard is evaluated. The caller grantedcontents: readon the reasoning thatupload-assets: falsemeans that job never runs. That reasoning is correct about runtime and irrelevant to startup.Found by dispatching the workflow rather than reading it. A release pipeline that has never been executed is not a release pipeline.
upload-assetsis still false, so the generator never attaches anything, and thereleasejob remains the only thing that touches release assets.