fix: Fix bad format in docs/reqstool/software_verification_cases.yml - #121
Merged
Conversation
lfvdavid
marked this pull request as draft
October 24, 2024 14:01
lfvjimisola
suggested changes
Oct 25, 2024
| @@ -1,6 +1,6 @@ | |||
| # yaml-language-server: $schema=https://raw.githubusercontent.com/Luftfartsverket/reqstool-client/main/src/reqstool/resources/schemas/v1/reqstool_config.schema.json | |||
|
|
|||
| type: default | |||
Contributor
There was a problem hiding this comment.
Why this change? I've updated the docs regarding reqstool_config's new format in the docs on my branch.
Contributor
Author
There was a problem hiding this comment.
Reverted, have you also fixed the Requirements annotation? If so we can just close this PR.
Comment on lines
43
to
46
| not (os.getenv("GITHUB_TOKEN") or not os.getenv("GITLAB_TOKEN")), | ||
| reason="Test needs GITLAB_TOKEN or GITHUB_TOKEN environment variable to be set", | ||
| ) | ||
| def test_basic_maven(): |
Contributor
There was a problem hiding this comment.
I've fixed this and updated the pytest exeuction in workflow on my branch as per our jitsi meet earlier today. So, no need for this.
@SVCs("SVC_003", "SVC_008")
@pytest.mark.slow
@pytest.mark.integration
@pytest.mark.skipif(
not (os.getenv("GITHUB_TOKEN")),
reason="Test needs GITHUB_TOKEN",
)
def test_basic_maven():
lfvjimisola
approved these changes
Oct 30, 2024
lfvjimisola
marked this pull request as ready for review
October 30, 2024 10:58
lfvjimisola
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix requirements list assigned to a svc and changed type to
pythonin reqstool_config