Getters/Setters for wrapped attributes #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requests-oauthlib wraps WebApplicationClient, so the values on that client should be exposed on the wrapper.
singingwolfboy
force-pushed
the
getters-setters
branch
from
b51f650 to
96529be
Compare
singingwolfboy
force-pushed
the
getters-setters
branch
from
96529be to
a272b68
Compare
Member
There was a problem hiding this comment.
Why did we lose this function call?
Member
Author
There was a problem hiding this comment.
Because this function call is in the setter for self.token, so it gets called automatically on line 68.
Member
|
Thanks @singingwolfboy! |
Lukasa
added a commit
that referenced
this pull request
Dec 13, 2015
Getters/Setters for wrapped attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code that uses requests-oauthlib may want to modify values in the oauth2 session client, but requests-oauthlib doesn't expose them in a consistent way. By exposing getters and setters, other software and libraries that wrap requests-oauthlib can modify these values in a consistent way.