refactor: migrate core DOM tree interfaces - #302
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08f7c6a1ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
08f7c6a to
5a859e2
Compare
5a859e2 to
b327f5d
Compare
b327f5d to
0268243
Compare
d7bb287 to
4f100d7
Compare
4f100d7 to
62c8673
Compare
62c8673 to
0c3bb67
Compare
0c3bb67 to
ea6fb05
Compare
9727a53 to
f8a846b
Compare
f8a846b to
02905ae
Compare
02905ae to
87a2c53
Compare
de5f8de to
b892660
Compare
| [See StaticRange on MDN](https://developer.mozilla.org/docs/Web/API/StaticRange) | ||
| */ | ||
| type t = AbstractRange.t = private { | ||
| ...AbstractRange.t, |
There was a problem hiding this comment.
Is this so that completions actually show some contents?
There was a problem hiding this comment.
Yeah. It's a pattern that @tsnobip showed to me.
There was a problem hiding this comment.
Yes. The explicit private record keeps the inherited fields visible in editor completions; the type equation also preserves the intended identity with AbstractRange.t for this fieldless subtype. A stack-wide consistency audit is tracked in the parent issue follow-up checklist.
ec61d7d to
d06a446
Compare
d06a446 to
c39776a
Compare
c39776a to
13a324f
Compare
Tracking issue: #342
Summary
DOMTreeAttr,AbstractRange,StaticRange,CDATASection, andProcessingInstructionTemporary state
DOMTreetypes used here are still aliases to the old recursive definitions from refactor: introduce DOMTree compatibility foundation #301DomTypesso this layer compiles independentlyDOMTreeconcrete, relocates the remaining helpers, and deletesDomTypesReview focus
Verification
npm run buildnpm testnpm run format:check