refactor: establish ViewTransitions folder feature - #316
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16b0709e9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "WebAPI.Fetch": ["WebAPI.Event", "WebAPI.File", "WebAPI.URL", "Fetch"], | ||
| "WebAPI.Performance": ["WebAPI.Event", "Performance"] | ||
| "WebAPI.Performance": ["WebAPI.Event", "Performance"], | ||
| "WebAPI.ViewTransitions": ["WebAPI.Event", "ViewTransitions"] |
There was a problem hiding this comment.
Keep the supported ViewTransitions feature buildable
When a consumer selects --features WebAPI.ViewTransitions, this new implication transitively activates WebAPI.Event and WebAPI.DOM, as specified by rescript build --help, but not the DOMPlatform source containing DOMStringMap. I checked this feature combination from a clean build: it now exits with src/DOM/DOMTree.res:982 reporting that DOMStringMap cannot be found, whereas the same selector compiled successfully before this commit. Thus the newly supported public feature cannot actually be selected on its own; its implication set must include every source needed by the activated DOM modules.
Useful? React with 👍 / 👎.
16b0709 to
788ef48
Compare
Tracking issue: #342
Stack context
Part 6 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #315.
Summary
src/ViewTransitionsto the targetsrc/view-transitionsfolderViewTransitionsfeatureWebAPI.ViewTransitionsfeature with itsWebAPI.EventdependencyWebAPI.ViewTransitionmoduleThe internal
ViewTransitionsTypeshelper stays private inside the complete folder.Temporary state
Review focus
WebAPI.ViewTransitions -> WebAPI.Event + ViewTransitionsimplicationVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,ViewTransitionsnpm run buildnpm testnpm run format:checkgit diff --check