refactor: establish Animation folder feature - #323
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70d2716e89
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| "dir": "src/animation", | ||
| "subdirs": true, | ||
| "feature": "Animation", |
There was a problem hiding this comment.
Include animation modules in DOM's feature closure
When a consumer selects WebAPI.DOM but omits the new WebAPI.Animation, rescript build --features excludes this tagged directory—as the CLI help specifies for directories outside the selected or implied features—while still compiling src/DOM/Element.res, Document.res, and ShadowRoot.res, which reference Animation and AnimationEffect. I confirmed this by building with every source feature except Animation; compilation fails at Element.res:32 because Animation cannot be found. Keep these bindings in DOM's closure or move/gate every DOM module that depends on them.
Useful? React with 👍 / 👎.
Tracking issue: #342
Stack context
Part 13 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #322.
Summary
src/animationfolder on the unqualified internalAnimationfeatureAnimation,AnimationEffect, andDocumentTimelineout of the legacy broad DOM folderWebAPI.Animationfeature with itsWebAPI.EventdependencyTemporary state
Review focus
WebAPI.Animation -> WebAPI.Event + AnimationimplicationVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,Animationnpm run buildnpm testnpm run format:checkgit diff --check