Skip to content

refactor: establish Animation folder feature - #323

Open
jderochervlk wants to merge 1 commit into
codex/option5-messaging-folderfrom
codex/option5-animation-folder
Open

refactor: establish Animation folder feature#323
jderochervlk wants to merge 1 commit into
codex/option5-messaging-folderfrom
codex/option5-animation-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 13 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #322.

Summary

  • add the target src/animation folder on the unqualified internal Animation feature
  • move Animation, AnimationEffect, and DocumentTimeline out of the legacy broad DOM folder
  • add the supported WebAPI.Animation feature with its WebAPI.Event dependency
  • preserve all three flat public module paths and binding signatures

Temporary state

  • this PR introduces no compatibility aliases, file exclusions, or module slices; the Animation folder membership and public implication are final
  • DOMNodes interfaces currently call Animation APIs directly; that dependency will be resolved explicitly when the DOMNodes boundary is implemented rather than hidden in this layer

Review focus

  • the WebAPI.Animation -> WebAPI.Event + Animation implication
  • complete Animation folder membership
  • unchanged public APIs

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,Animation
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70d2716e89

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rescript.json
{
"dir": "src/animation",
"subdirs": true,
"feature": "Animation",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Include animation modules in DOM's feature closure

When a consumer selects WebAPI.DOM but omits the new WebAPI.Animation, rescript build --features excludes this tagged directory—as the CLI help specifies for directories outside the selected or implied features—while still compiling src/DOM/Element.res, Document.res, and ShadowRoot.res, which reference Animation and AnimationEffect. I confirmed this by building with every source feature except Animation; compilation fails at Element.res:32 because Animation cannot be found. Keep these bindings in DOM's closure or move/gate every DOM module that depends on them.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant