refactor: establish WebAudio folder feature - #329
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d44e1a7b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| { | ||
| "dir": "src/WebAudio", | ||
| "dir": "src/web-audio", |
There was a problem hiding this comment.
Keep the WebAudio documentation source path in sync
When the API documentation routes are generated, docs/utils.js still derives this feature's path from featureSpecs, where dirName remains WebAudio; it therefore probes src/WebAudio/WebAudioTypes.res and filters the module out because that path no longer exists. As a result, this rename removes WebAudio and all of its child modules from the generated API documentation unless the documentation metadata is updated or made to use the configured source directory.
Useful? React with 👍 / 👎.
Tracking issue: #342
Stack context
Part 19 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #328.
Summary
src/WebAudioto the targetsrc/web-audiofolderWebAudiofeatureWebAPI.WebAudio -> WebAPI.Media + WebAPI.Messaging + WebAudiofeatureDependency note
The Option 5 proposal listed only Media as a public dependency. The current bindings also expose
MessagePortfromAudioWorkletNode.port, so the compiler-proven closure additionally requiresWebAPI.Messaging. This PR records the real public signature dependency at the domain level.Temporary state
WebAPI.DOMsource entry remains until its remaining interfaces have been assignedReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTML,Media,Messaging,WebAudionpm run buildnpm testnpm run format:checkgit diff --check