Skip to content

refactor: establish UIEvents folder feature - #332

Open
jderochervlk wants to merge 1 commit into
codex/option5-observers-folderfrom
codex/option5-ui-events-folder
Open

refactor: establish UIEvents folder feature#332
jderochervlk wants to merge 1 commit into
codex/option5-observers-folderfrom
codex/option5-ui-events-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 22 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #331.

Summary

  • rename src/UIEvents to the target src/ui-events folder
  • switch the folder to the unqualified internal UIEvents feature
  • add the supported WebAPI.UIEvents -> WebAPI.DOMNodes + WebAPI.File + UIEvents feature
  • preserve all existing flat UI event module paths and binding signatures

Temporary state

  • the legacy broad WebAPI.DOM source entry remains until its remaining interfaces have been assigned
  • final feature-graph guardrails and cleanup remain deferred until the stack is complete

Review focus

  • the lowercase folder/internal feature transition
  • the DOMNodes/File dependency closure
  • preservation of flat public modules

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,UIEvents
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e7487d1ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rescript.json
},
{
"dir": "src/UIEvents",
"dir": "src/ui-events",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update documentation metadata for the renamed UIEvents folder

After moving this source to src/ui-events, the UIEvents API disappears from the generated documentation: featureSpecs still defines its dirName/sourceDir as UIEvents/src/UIEvents (scripts/unmonorepo/feature-spec.mjs), while docs/utils.js builds apiModules from that path and filters it out when UiEventsTypes.res is not found. Update the metadata or make the documentation tooling derive the new configured source directory so these public modules remain discoverable.

Useful? React with 👍 / 👎.

@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 9e7487d to 3614687 Compare August 4, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant