refactor: establish Navigator folder feature - #336
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 598c76647c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| { | ||
| "dir": "src/Clipboard", | ||
| "dir": "src/navigator", |
There was a problem hiding this comment.
Register src/navigator with the docs generator
When CI runs npm run build:docs, the prebuild:docs hook processes every public source file, but docs/llm.js derives its supported directory map from featureSpecs, which contains no navigator entry; processing any of these newly public files therefore reaches moduleNameForFile and throws Unsupported source directory for documentation. Update the docs directory mapping (or stop relying on the legacy feature specs) so the documentation build can handle this source.
Useful? React with 👍 / 👎.
598c766 to
e7beeae
Compare
Tracking issue: #342
Stack context
Part 26 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #335.
Summary
src/navigatorfolder on the unqualified internalNavigatorfeatureNavigatorinterface out of the legacy DOM folderDependency note
The provisional Option 5 map listed only DOMPlatform and Device. The current
Navigatorsignatures also expose media capabilities/devices/session, storage, service workers, fetch/file/url payloads, clipboard, credentials, and permissions. The broader compiler-proven closure records that existing surface rather than silently omitting modules required by the public interface.Temporary state
WebAPI.DOMsource entry remains for Window, Document, and the final unassigned interfacesReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTML,Media,URL,Fetch,Storage,Messaging,Workers,Device,Navigatornpm run buildnpm testnpm run format:checkgit diff --check