feat: better accessibility defaults#3546
Conversation
Signed-off-by: gabriel miranda <gabriel@resend.com>
Signed-off-by: gabriel miranda <gabriel@resend.com>
Signed-off-by: gabriel miranda <gabriel@resend.com>
Signed-off-by: gabriel miranda <gabriel@resend.com>
Signed-off-by: gabriel miranda <gabriel@resend.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 5ba6f02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Signed-off-by: gabriel miranda <gabriel@resend.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Requires human review: Adding a <title> tag inside the email body rather than the could produce invalid HTML and unexpected behavior in email clients, so this change requires human review to verify its correctness.
Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 4 files
Confidence score: 4/5
- This PR is likely safe to merge with minimal risk, since the only reported issue is moderate (5/10) and focused on markup validity rather than a clear functional break.
- In
packages/react-email/src/components/preview/preview.tsx, emitting a<title>fromPreviewcan place metadata outside<head>, which may lead to invalid HTML and inconsistent handling by clients. - Pay close attention to
packages/react-email/src/components/preview/preview.tsx- ensure<title>generation is moved to a proper<head>context or removed from this component.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Signed-off-by: gabriel miranda <gabriel@resend.com>
There was a problem hiding this comment.
0 issues found across 7 files (changes from recent commits).
Auto-approved: The PR introduces low-risk accessibility improvements (default dir/lang on Body, default empty alt on Img, role='presentation' on Markdown tables, and a <title> from Preview). All changes are non-breaking, props override defaults, tests are updated, and the diff is small...
Re-trigger cubic
4 participants
pushing to improve in the directions that https://emailmarkup.org/en/reports/accessibility/2026/ has
Summary by cubic
Improve accessibility defaults across
react-emailcomponents with no breaking changes. Better screen reader behavior, RTL/i18n support, clearer previews, and a changeset to ship a patch release.Body: sets dir="ltr" and lang="en" on and its inner ; props still override.Img: defaults to alt="" when not provided.Markdown: tables render with role="presentation".Preview: injects preview text into a <title> before the hidden preheader.Written for commit 5ba6f02. Summary will update on new commits. Review in cubic