Skip to content

fix(editor): use mark inline styles on the code block#3647

Merged
danilowoz merged 1 commit into
canaryfrom
07-13-fix_editor_use_mark_inline_styles_on_the_code_block
Jul 13, 2026
Merged

fix(editor): use mark inline styles on the code block#3647
danilowoz merged 1 commit into
canaryfrom
07-13-fix_editor_use_mark_inline_styles_on_the_code_block

Conversation

@danilowoz

@danilowoz danilowoz commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary by cubic

Ensure inline styles on the code mark are preserved when composing emails in @react-email/editor. The serializer now merges mark.attrs.style with node styles, fixing lost background, padding, and font styles from imported HTML.

Written for commit 99717e1. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment Jul 13, 2026 9:56am
react-email-demo Ready Ready Preview, Comment Jul 13, 2026 9:56am

@changeset-bot

changeset-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 99717e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@react-email/editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jul 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@react-email/editor@3647

commit: 99717e1

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Fix code mark serializer to merge inline styles from mark attrs, a small low-risk bug fix.

Re-trigger cubic

@danilowoz
danilowoz merged commit 32d8d95 into canary Jul 13, 2026
19 of 20 checks passed
@danilowoz
danilowoz deleted the 07-13-fix_editor_use_mark_inline_styles_on_the_code_block branch July 13, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant