fix(editor): preserve paragraph styles when splitting with Enter by vcapretz · Pull Request #3705 · resend/react-email

vcapretz · 2026-08-10T14:52:38Z

Summary

Pressing Enter in the middle of a paragraph with custom styles (e.g. a font size set via the inspector) split the paragraph but stripped the styles from the second half. Text color survived because it lives as a mark on the text nodes, while font size lives on the paragraph's style attribute.

The split itself was never the problem: TipTap attributes default to keepOnSplit: true, so the style attribute was correctly copied to the new paragraph. The bug was an Enter keyboard shortcut in the StyleAttribute extension that ran resetAttributes('paragraph', 'style') in a requestAnimationFrame callback right after the split — wiping the styles off the paragraph the cursor landed in. ClassAttribute had the identical reset for class.

Those shortcuts exist for a reason, though: without them, pressing Enter at the end of a styled paragraph would produce an empty paragraph that inherits the custom style/class, and everything typed next would continue in it. So instead of removing them, this PR makes the reset conditional:

Keep the Enter shortcuts in StyleAttribute and ClassAttribute, but skip the reset when the selection end is not at the end of its block — i.e. when Enter actually splits text and the content moved into the new paragraph must keep its style/class
Still reset when Enter creates a fresh empty paragraph (cursor at the end of the block), preserving the original "new paragraph starts with default styles" behavior
This also fixes pressing Enter at the start of a styled paragraph, which previously wiped the style of the existing content
Regression tests cover both cases: mid-paragraph split keeps style/class on both halves, and Enter at the end still yields a default new paragraph

Test plan

Browser integration suite passes (9 tests), including the new mid-split and end-of-paragraph specs
Editor unit suite: 308 passed, 0 failed (23 spec files fail to load with a pre-existing react-email package-resolution error, reproducible on a clean canary checkout)
Manual check in the editor: set a custom font size on a paragraph, press Enter mid-text, confirm both paragraphs keep the size; press Enter at the end, confirm the new paragraph starts with default styles

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>

vercel · 2026-08-10T14:52:41Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
react-email	Ready	Preview	Aug 10, 2026 3:59pm
react-email-demo	Ready	Preview	Aug 10, 2026 3:59pm

changeset-bot · 2026-08-10T14:52:46Z

🦋 Changeset detected

Latest commit: c5deffc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@react-email/editor	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gabrielmfern · 2026-08-10T14:54:10Z

@cursor can you add a changeset to this pull request? it should be one short sentence

cursor · 2026-08-10T14:54:20Z

Done — I added a changeset to the PR. The new file .changeset/tidy-parks-look.md declares a patch bump for @react-email/editor with the one-line description "Preserve paragraph style and class attributes when splitting a paragraph with Enter". It's committed and pushed to the PR branch, so the changeset-bot warning should clear on the next check.

pkg-pr-new · 2026-08-10T14:54:44Z

Open in StackBlitz

npm i https://pkg.pr.new/@react-email/editor@3705

commit: c5deffc

Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>

…ration suite Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>

gabrielmfern · 2026-08-10T15:01:24Z

@cursor lint

cursor · 2026-08-10T15:01:32Z

Fixed the lint failure. Biome's formatter was flagging a stray blank line before the closing }); in both style-attribute.tsx and class-attribute.tsx — leftovers from removing the addKeyboardShortcuts blocks. I ran Biome's auto-fix on both files, confirmed the full repo pnpm lint now exits cleanly (the one remaining warning about !important in a CSS file is pre-existing and doesn't fail the check), and pushed the fix to the PR branch, so the lint job should go green on the new commit.

Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>

klotty

0 issues found across 4 files (changes from recent commits).

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Auto-approved: Focused bug fix: removes the Enter shortcuts that reset paragraph style/class after a split, and adds a regression test showing both paragraphs retain the attributes. No public, operational, or data tradeoff remains for human review.

Re-trigger cubic}

…mpty paragraphs Instead of removing the StyleAttribute/ClassAttribute Enter shortcuts, keep them but skip the reset when Enter splits a paragraph mid-text, so the content moved into the new paragraph keeps its style/class. Pressing Enter at the end of a styled paragraph still starts a fresh default paragraph, preserving the original intent of the shortcuts. Co-authored-by: Cursor <cursoragent@cursor.com>

cubic-dev-ai

All reported issues were addressed across 3 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

Dismissed because Cubic found issues in a newer review.

cubic-dev-ai

0 issues found across 2 files (changes from recent commits).

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.

Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 1 file (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

fix(editor): preserve paragraph styles when splitting with Enter

469e512

Co-authored-by: Cursor <cursoragent@cursor.com>

vcapretz self-assigned this Aug 10, 2026

vercel Bot deployed to Preview – react-email August 10, 2026 14:53 View deployment

vercel Bot deployed to Preview – react-email-demo August 10, 2026 14:54 View deployment

chore: add changeset

fa788e0

Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>

vercel Bot deployed to Preview – react-email August 10, 2026 14:55 View deployment

gabrielmfern reviewed Aug 10, 2026

View reviewed changes

Comment thread packages/editor/src/extensions/paragraph-split.spec.ts Outdated

vercel Bot deployed to Preview – react-email-demo August 10, 2026 14:56 View deployment

test(editor): move paragraph split regression test into browser integ…

20742f7

…ration suite Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>

vercel Bot deployed to Preview – react-email August 10, 2026 15:00 View deployment

vercel Bot deployed to Preview – react-email-demo August 10, 2026 15:02 View deployment

style(editor): remove trailing blank lines flagged by biome

46228c8

Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>

vercel Bot deployed to Preview – react-email August 10, 2026 15:04 View deployment

vercel Bot deployed to Preview – react-email-demo August 10, 2026 15:06 View deployment

klotty previously approved these changes Aug 10, 2026

View reviewed changes

vercel Bot deployed to Preview – react-email August 10, 2026 15:17 View deployment

vercel Bot deployed to Preview – react-email-demo August 10, 2026 15:19 View deployment

cubic-dev-ai Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread packages/editor/src/extensions/class-attribute.tsx

Comment thread packages/editor/src/extensions/style-attribute.tsx

fixes style

b2c4193

vercel Bot deployed to Preview – react-email August 10, 2026 15:38 View deployment

vercel Bot deployed to Preview – react-email-demo August 10, 2026 15:39 View deployment

cubic-dev-ai Bot reviewed Aug 10, 2026

View reviewed changes

danilowoz approved these changes Aug 10, 2026

View reviewed changes

skip flaky test

c5deffc

vercel Bot deployed to Preview – react-email August 10, 2026 15:58 View deployment

vercel Bot deployed to Preview – react-email-demo August 10, 2026 15:59 View deployment

cubic-dev-ai Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread apps/web/src/app/api/check-spam/check-spam.spec.tsx

vcapretz merged commit b039b36 into canary Aug 10, 2026
20 checks passed

vcapretz deleted the fix/editor-preserve-paragraph-styles-on-split branch August 10, 2026 16:01

Uh oh!

Conversation

vcapretz commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

vercel Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

gabrielmfern commented Aug 10, 2026

Uh oh!

cursor Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

gabrielmfern commented Aug 10, 2026

Uh oh!

cursor Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

klotty left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vcapretz commented Aug 10, 2026 •

edited

Loading

vercel Bot commented Aug 10, 2026 •

edited

Loading

changeset-bot Bot commented Aug 10, 2026 •

edited

Loading

cursor Bot commented Aug 10, 2026 •

edited

Loading

pkg-pr-new Bot commented Aug 10, 2026 •

edited

Loading

cursor Bot commented Aug 10, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading